Skip to content

Commit 73cf4a8

Browse files
ENGCOM-2412: [Backport] Issue 5316 #16916
2 parents c90c183 + 7141261 commit 73cf4a8

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

lib/internal/Magento/Framework/View/Template/Html/Minifier.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,8 @@ public function minify($file)
131131
'#(?<!:|\\\\|\'|")//(?!\s*\<\!\[)(?!\s*]]\>)[^\n\r]*#',
132132
'',
133133
preg_replace(
134-
'#(?<!:|\'|")//[^\n\r]*(\s\?\>)#',
135-
'$1',
134+
'#(?<!:|\'|")//[^\n\r]*(\?\>)#',
135+
' $1',
136136
preg_replace(
137137
'#(?<!:)//[^\n\r]*(\<\?php)[^\n\r]*(\s\?\>)[^\n\r]*#',
138138
'',

lib/internal/Magento/Framework/View/Test/Unit/Template/Html/MinifierTest.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,11 @@ public function testMinify()
156156
<?php echo '//some.link.com/' ?>
157157
<em>inline text</em>
158158
<a href="http://www.<?php echo 'hi' ?>"></a>
159+
<?php// if (\$block->getSomeVariable() > 1):?>
160+
<?php echo \$block->getChildHtml('someChildBlock'); ?>
161+
<?php //else:?>
162+
<?php // echo \$block->getChildHtml('anotherChildBlock'); ?>
163+
<?php // endif; ?>
159164
</body>
160165
</html>
161166
TEXT;
@@ -179,7 +184,7 @@ public function testMinify()
179184
}
180185
});
181186
//]]>
182-
</script><?php echo "http://some.link.com/" ?> <?php echo "//some.link.com/" ?> <?php echo '//some.link.com/' ?> <em>inline text</em> <a href="http://www.<?php echo 'hi' ?>"></a></body></html>
187+
</script><?php echo "http://some.link.com/" ?> <?php echo "//some.link.com/" ?> <?php echo '//some.link.com/' ?> <em>inline text</em> <a href="http://www.<?php echo 'hi' ?>"></a> <?php ?> <?php echo \$block->getChildHtml('someChildBlock'); ?> <?php ?> <?php ?> <?php ?></body></html>
183188
TEXT;
184189

185190
$this->appDirectoryMock->expects($this->once())

0 commit comments

Comments
 (0)