Skip to content

Commit 7b3359d

Browse files
committed
Merge remote-tracking branch 'origin/2.4.4-develop' into ACP2E-120-2.4.4
2 parents 5ef9d7f + b225913 commit 7b3359d

File tree

8 files changed

+75
-21
lines changed

8 files changed

+75
-21
lines changed

app/code/Magento/Catalog/view/adminhtml/web/catalog/product/composite/configure.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,9 @@ define([
230230
if (response.error) {
231231
this.blockMsg.show();
232232
this.blockMsgError.innerHTML = response.message;
233-
this.blockCancelBtn.hide();
233+
if(this.blockCancelBtn) {
234+
this.blockCancelBtn.hide();
235+
}
234236
this.setConfirmCallback(listType, null);
235237
this._showWindow();
236238
}
@@ -584,7 +586,9 @@ define([
584586
this.blockFormFields.update();
585587
this.blockMsg.hide();
586588
this.blockMsgError.update();
587-
this.blockCancelBtn.show();
589+
if(this.blockCancelBtn) {
590+
this.blockCancelBtn.show();
591+
}
588592
break;
589593
default:
590594
// search in list types for its cleaning
@@ -603,7 +607,9 @@ define([
603607
this.blockFormFields.update();
604608
this.blockMsg.hide();
605609
this.blockMsgError.update();
606-
this.blockCancelBtn.show();
610+
if(this.blockCancelBtn) {
611+
this.blockCancelBtn.show();
612+
}
607613
}
608614
break;
609615
}

app/code/Magento/MediaGalleryUi/view/adminhtml/web/js/grid/columns/image/insertImageAction.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ define([
4949
showLoader: true
5050
}).done($.proxy(function (data) {
5151
if (typeof targetElement === 'function') {
52-
targetElement(data.content);
52+
targetElement(data.content, {text: record['title']});
5353
} else if (targetElement.is('textarea')) {
5454
this.insertAtCursor(targetElement.get(0), data.content);
5555
targetElement.focus();
Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
11+
<test name="AdminCreateOrderWithConfigurableProductTest">
12+
<annotations>
13+
<title value="Create Order in Admin with simple product"/>
14+
<stories value="AC-2040"/>
15+
<description value="Create order with configurable product."/>
16+
<features value="Sales"/>
17+
<testCaseId value="AC-2040"/>
18+
<severity value="MAJOR"/>
19+
<group value="Sales"/>
20+
</annotations>
21+
<before>
22+
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
23+
<createData entity="_defaultCategory" stepKey="createCategory"/>
24+
<actionGroup ref="CreateConfigurableProductActionGroup" stepKey="createConfigurableProduct">
25+
<argument name="product" value="_defaultProduct"/>
26+
<argument name="category" value="$$createCategory$$"/>
27+
</actionGroup>
28+
<createData entity="Simple_US_Customer" stepKey="createCustomer"/>
29+
</before>
30+
<actionGroup ref="NavigateToNewOrderPageExistingCustomerActionGroup" stepKey="navigateToNewOrderWithExistingCustomer">
31+
<argument name="customer" value="$$createCustomer$$"/>
32+
</actionGroup>
33+
<actionGroup ref="AddConfigurableProductToOrderActionGroup" stepKey="addFirstConfigurableProductToOrder">
34+
<argument name="product" value="_defaultProduct"/>
35+
<argument name="attribute" value="colorProductAttribute"/>
36+
<argument name="option" value="colorProductAttribute1"/>
37+
</actionGroup>
38+
<actionGroup ref="SelectCashOnDeliveryPaymentMethodActionGroup" stepKey="selectPaymentMethod"/>
39+
<actionGroup ref="AdminSubmitOrderActionGroup" stepKey="submitOrder"/>
40+
<actionGroup ref="VerifyCreatedOrderInformationActionGroup" stepKey="verifyCreatedOrderInformation"/>
41+
<after>
42+
<deleteData createDataKey="createCustomer" stepKey="deleteCustomer"/>
43+
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
44+
<actionGroup ref="DeleteProductBySkuActionGroup" stepKey="deleteConfigurableProduct">
45+
<argument name="sku" value="{{_defaultProduct.sku}}"/>
46+
</actionGroup>
47+
<magentoCLI stepKey="reindex" command="indexer:reindex"/>
48+
<magentoCLI stepKey="flushCache" command="cache:flush"/>
49+
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
50+
</after>
51+
52+
</test>
53+
</tests>

app/code/Magento/Sales/view/adminhtml/web/order/create/giftmessage.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,7 @@ define([
207207
'margin-top' : topMargin,
208208
'z-index': 1000
209209
});
210+
jQuery(this).closest('.ui-dialog').nextAll('.ui-widget-overlay').css('z-index', 999);
210211
},
211212
close: function () {
212213
jQuery(this).closest('.ui-dialog').removeClass('ui-dialog-active');

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"laminas/laminas-view": "~2.14.1",
6262
"league/flysystem": "~2.3.2",
6363
"league/flysystem-aws-s3-v3": "^2.0",
64-
"magento/composer": "1.8.x-dev as 1.8.0",
64+
"magento/composer": "~1.8.0",
6565
"magento/composer-dependency-version-audit-plugin": "~0.1",
6666
"magento/magento-composer-installer": "0.3.*@beta",
6767
"magento/zendframework1": "1.14.6-beta2 as 1.14.6",

composer.lock

Lines changed: 7 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dev/tests/integration/testsuite/Magento/Ui/Component/ConfigurationTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
use Magento\Framework\Component\ComponentRegistrar;
1111
use Magento\Framework\Component\DirSearch;
1212
use Magento\Framework\Exception\FileSystemException;
13+
use Magento\Framework\Exception\ValidatorException;
1314
use Magento\Framework\Filesystem;
1415
use Magento\Framework\Filesystem\Directory\ReadInterface;
1516
use Magento\TestFramework\Helper\Bootstrap;
@@ -99,7 +100,7 @@ public function testConfiguration()
99100
// or some modules can be in `vendor` directory (like bundled extensions)
100101
try {
101102
$content = $this->appDir->readFile($this->appDir->getRelativePath($fullPath));
102-
} catch (FileSystemException $e) {
103+
} catch (ValidatorException $e) {
103104
$content = $this->rootDir->readFile($this->rootDir->getRelativePath($fullPath));
104105
}
105106
$this->assertConfigurationSemantic($this->getDom($content), $result);

lib/web/mage/adminhtml/browser.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ define([
307307
showLoader: true
308308
}).done($.proxy(function (data) {
309309
if (typeof targetEl === 'function') {
310-
targetEl(data);
310+
targetEl(data, {text: fileRow.find('img').attr('alt')});
311311
} else if (targetEl.is('textarea')) {
312312
this.insertAtCursor(targetEl.get(0), data);
313313
} else {

0 commit comments

Comments
 (0)