MAGETWO-30415: [GITHUB] \Magento\Framework\Pricing\PriceCurrencyInterface depends on Magento application code #682

Yu Tang · Yu Tang · commit 819015cc492b · 2015-01-09T09:40:24.000-06:00
diff --git a/app/code/Magento/Directory/Model/PriceCurrency.php b/app/code/Magento/Directory/Model/PriceCurrency.php
@@ -57,13 +57,7 @@ public function convert($amount, $scope = null, $currency = null)
     }
 
     /**
-     * Convert and round price value for specified store or passed currency
-     *
-     * @param float $amount
-     * @param null|string|bool|int|\Magento\Store\Model\Store $store
-     * @param Currency|string|null $currency
-     * @param int $precision
-     * @return float
+     * {@inheritdoc}
      */
     public function convertAndRound($amount, $store = null, $currency = null, $precision = self::DEFAULT_PRECISION)
     {
diff --git a/lib/internal/Magento/Framework/Pricing/PriceCurrencyInterface.php b/lib/internal/Magento/Framework/Pricing/PriceCurrencyInterface.php
@@ -29,12 +29,12 @@ public function convert($amount, $scope = null, $currency = null);
      * Convert and round price value
      *
      * @param float $amount
-     * @param null|string|bool|int|\Magento\Store\Model\Store $store
-     * @param \Magento\Directory\Model\Currency|string|null $currency
+     * @param null|string|bool|int|\Magento\Framework\App\ScopeInterface $scope
+     * @param \Magento\Framework\Model\AbstractModel|string|null $currency
      * @param int $precision
      * @return float
      */
-    public function convertAndRound($amount, $store = null, $currency = null, $precision = self::DEFAULT_PRECISION);
+    public function convertAndRound($amount, $scope = null, $currency = null, $precision = self::DEFAULT_PRECISION);
 
     /**
      * Format price value

Original file line number	Diff line number	Diff line change
`@@ -57,13 +57,7 @@ public function convert($amount, $scope = null, $currency = null)`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`/**`
`60`		`- * Convert and round price value for specified store or passed currency`
`61`		`- *`
`62`		`- * @param float $amount`
`63`		`- * @param null\|string\|bool\|int\|\Magento\Store\Model\Store $store`
`64`		`- * @param Currency\|string\|null $currency`
`65`		`- * @param int $precision`
`66`		`- * @return float`
	`60`	`+ * {@inheritdoc}`
`67`	`61`	`*/`
`68`	`62`	`public function convertAndRound($amount, $store = null, $currency = null, $precision = self::DEFAULT_PRECISION)`
`69`	`63`	`{`