Skip to content

Commit 8280a9a

Browse files
author
Oleksandr Iegorov
committed
MC-32022: X-Magento-Tags header too large
1 parent 27f2363 commit 8280a9a

File tree

5 files changed

+37
-203
lines changed

5 files changed

+37
-203
lines changed

app/code/Magento/ConfigurableProduct/Model/Plugin/Frontend/ProductIdentitiesExtender.php

Lines changed: 0 additions & 48 deletions
This file was deleted.

app/code/Magento/ConfigurableProduct/Test/Unit/Model/Plugin/Frontend/ProductIdentitiesExtenderTest.php

Lines changed: 0 additions & 77 deletions
This file was deleted.

app/code/Magento/ConfigurableProduct/etc/frontend/di.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@
1010
<type name="Magento\ConfigurableProduct\Model\ResourceModel\Attribute\OptionSelectBuilderInterface">
1111
<plugin name="Magento_ConfigurableProduct_Plugin_Model_ResourceModel_Attribute_InStockOptionSelectBuilder" type="Magento\ConfigurableProduct\Plugin\Model\ResourceModel\Attribute\InStockOptionSelectBuilder"/>
1212
</type>
13-
<type name="Magento\Catalog\Model\Product">
14-
<plugin name="product_identities_extender" type="Magento\ConfigurableProduct\Model\Plugin\Frontend\ProductIdentitiesExtender" />
15-
</type>
1613
<type name="Magento\ConfigurableProduct\Model\Product\Type\Configurable">
1714
<plugin name="used_products_cache" type="Magento\ConfigurableProduct\Model\Plugin\Frontend\UsedProductsCache" />
1815
</type>

dev/tests/integration/testsuite/Magento/ConfigurableProduct/Model/Plugin/Frontend/ProductIdentitiesExtenderTest.php

Lines changed: 0 additions & 73 deletions
This file was deleted.

dev/tests/integration/testsuite/Magento/ConfigurableProduct/Model/ProductTest.php

Lines changed: 37 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,42 @@ public function testGetIdentities()
2222
$simple10Product = $productRepository->get('simple_10');
2323
$simple20Product = $productRepository->get('simple_20');
2424

25-
$this->assertEmpty(array_diff($confProduct->getIdentities(), $simple10Product->getIdentities()));
26-
$this->assertEmpty(array_diff($confProduct->getIdentities(), $simple20Product->getIdentities()));
25+
$this->assertNotEmpty(array_diff($confProduct->getIdentities(), $simple10Product->getIdentities()));
26+
$this->assertNotEmpty(array_diff($confProduct->getIdentities(), $simple20Product->getIdentities()));
27+
}
28+
29+
/**
30+
* Check that no children identities are added to the parent product in frontend area
31+
*
32+
* @magentoDataFixture Magento/ConfigurableProduct/_files/product_configurable.php
33+
* @magentoAppArea frontend
34+
* @return void
35+
*/
36+
public function testGetIdentitiesForConfigurableProductOnStorefront(): void
37+
{
38+
$productRepository = Bootstrap::getObjectManager()->get(ProductRepositoryInterface::class);
39+
$configurableProduct = $productRepository->get('configurable');
40+
$expectedIdentities = [
41+
'cat_p_' . $configurableProduct->getId(),
42+
'cat_p'
43+
];
44+
$this->assertEquals($expectedIdentities, $configurableProduct->getIdentities());
45+
}
46+
47+
/**
48+
* Check that no children identities are added to the parent product in frontend area
49+
*
50+
* @magentoDataFixture Magento/ConfigurableProduct/_files/product_configurable.php
51+
* @magentoAppArea adminhtml
52+
* @return void
53+
*/
54+
public function testGetIdentitiesForConfigurableProductInAdminArea(): void
55+
{
56+
$productRepository = Bootstrap::getObjectManager()->get(ProductRepositoryInterface::class);
57+
$configurableProduct = $productRepository->get('configurable');
58+
$expectedIdentities = [
59+
'cat_p_' . $configurableProduct->getId(),
60+
];
61+
$this->assertEquals($expectedIdentities, $configurableProduct->getIdentities());
2762
}
2863
}

0 commit comments

Comments
 (0)