ENGCOM-2030: Fix type hints and add undefined property in Webapi [2.3-develop] #16135

Author: Stanislav Idolov

app/code/Magento/Webapi/Controller/Soap.php

@@ -51,6 +51,11 @@ class Soap implements \Magento\Framework\App\FrontControllerInterface
      */
     protected $_errorProcessor;
 
+    /**
+     * @var \Magento\Framework\App\State
+     */
+    protected $_appState;
+
     /**
      * @var \Magento\Framework\Locale\ResolverInterface
      */

app/code/Magento/Webapi/Controller/Soap/Request/Handler.php

@@ -107,7 +107,7 @@ public function __construct(
      *
      * @param string $operation
      * @param array $arguments
-     * @return \stdClass|null
+     * @return array
      * @throws WebapiException
      * @throws \LogicException
      * @throws AuthorizationException

app/code/Magento/Webapi/Model/Plugin/GuestAuthorization.php

@@ -19,7 +19,7 @@ class GuestAuthorization
      * Check if resource for which access is needed has anonymous permissions defined in webapi config.
      *
      * @param \Magento\Framework\Authorization $subject
-     * @param callable $proceed
+     * @param \Closure $proceed
      * @param string $resource
      * @param string $privilege
      * @return bool true If resource permission is anonymous,

app/code/Magento/Webapi/Model/Soap/Server.php

@@ -31,7 +31,7 @@ class Server
     const REQUEST_PARAM_LIST_WSDL = 'wsdl_list';
 
     /**
-     * @var \Magento\Framework\App\AreaLIst
+     * @var \Magento\Framework\App\AreaList
      */
     protected $_areaList;
 

app/code/Magento/Webapi/Test/Unit/Model/Soap/FaultTest.php

@@ -125,7 +125,7 @@ public function testToXmlDeveloperModeOff()
     public function testToXmlDeveloperModeOn()
     {
         $this->_appStateMock->expects($this->any())->method('getMode')->will($this->returnValue('developer'));
-        $actualXml = $this->_soapFault->toXml(true);
+        $actualXml = $this->_soapFault->toXml();
         $this->assertContains('<m:Trace>', $actualXml, 'Exception trace is not found in XML.');
     }