#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products.

novikor · novikor · commit 9a35b459f1b3 · 2018-07-04T22:57:37.000+03:00
Made getProductToValidate method private according to Technical Guideline (2.7)
diff --git a/app/code/Magento/SalesRule/Model/Rule/Condition/Product.php b/app/code/Magento/SalesRule/Model/Rule/Condition/Product.php
@@ -36,7 +36,7 @@ protected function _addSpecialAttributes(array &$attributes)
      * @return \Magento\Catalog\Api\Data\ProductInterface|\Magento\Catalog\Model\Product
      * @throws \Magento\Framework\Exception\NoSuchEntityException
      */
-    protected function getProductToValidate(\Magento\Framework\Model\AbstractModel $model)
+    private function getProductToValidate(\Magento\Framework\Model\AbstractModel $model)
     {
         /** @var \Magento\Catalog\Model\Product $product */
         $product = $model->getProduct();

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ protected function _addSpecialAttributes(array &$attributes)`
`36`	`36`	`* @return \Magento\Catalog\Api\Data\ProductInterface\|\Magento\Catalog\Model\Product`
`37`	`37`	`* @throws \Magento\Framework\Exception\NoSuchEntityException`
`38`	`38`	`*/`
`39`		`- protected function getProductToValidate(\Magento\Framework\Model\AbstractModel $model)`
	`39`	`+ private function getProductToValidate(\Magento\Framework\Model\AbstractModel $model)`
`40`	`40`	`{`
`41`	`41`	`/** @var \Magento\Catalog\Model\Product $product */`
`42`	`42`	`$product = $model->getProduct();`