Skip to content

Commit 9df75b0

Browse files
committed
REFACTOR: Extract Action Groups to separate files (MFTF best practices)
1 parent 7311141 commit 9df75b0

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

app/code/Magento/Sales/Test/Mftf/ActionGroup/AdminOrderActionOnGridActionGroup.xml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,4 @@
1919
<click selector="{{AdminOrdersGridSection.dropdownActionItem(action)}}" stepKey="selectAction"/>
2020
<waitForPageLoad stepKey="waitForResults"/>
2121
</actionGroup>
22-
<actionGroup name="AdminTwoOrderActionOnGridActionGroup" extends="AdminOrderActionOnGridActionGroup">
23-
<arguments>
24-
<argument name="secondOrderId" type="string"/>
25-
</arguments>
26-
<checkOption selector="{{AdminOrdersGridSection.selectOrderID(secondOrderId)}}" stepKey="selectSecondOrder" after="waitForCheck"/>
27-
<waitForLoadingMaskToDisappear stepKey="waitForSecondCheck" after="selectSecondOrder"/>
28-
</actionGroup>
2922
</actionGroups>
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<actionGroup name="AdminTwoOrderActionOnGridActionGroup" extends="AdminOrderActionOnGridActionGroup">
12+
<arguments>
13+
<argument name="secondOrderId" type="string"/>
14+
</arguments>
15+
<checkOption selector="{{AdminOrdersGridSection.selectOrderID(secondOrderId)}}" stepKey="selectSecondOrder" after="waitForCheck"/>
16+
<waitForLoadingMaskToDisappear stepKey="waitForSecondCheck" after="selectSecondOrder"/>
17+
</actionGroup>
18+
</actionGroups>

0 commit comments

Comments
 (0)