Moving the method's logic into construct

eduard13 · eduard13 · commit 9e657ad9a269 · 2019-02-20T17:20:13.000+02:00
diff --git a/app/code/Magento/Catalog/Ui/DataProvider/Product/ProductDataProvider.php b/app/code/Magento/Catalog/Ui/DataProvider/Product/ProductDataProvider.php
@@ -68,7 +68,7 @@ public function __construct(
         $this->addFieldStrategies = $addFieldStrategies;
         $this->addFilterStrategies = $addFilterStrategies;
         $this->modifiersPool = $modifiersPool ?: ObjectManager::getInstance()->get(PoolInterface::class);
-        $this->setDefaultStoreToCollection();
+        $this->getCollection()->setStoreId(Store::DEFAULT_STORE_ID);
     }
 
     /**
@@ -142,12 +142,4 @@ public function getMeta()
 
         return $meta;
     }
-
-    /**
-     * Filter the product collection by Default Store if no filter is applied
-     */
-    private function setDefaultStoreToCollection()
-    {
-        $this->getCollection()->setStoreId(Store::DEFAULT_STORE_ID);
-    }
 }

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ public function __construct(`
`68`	`68`	`$this->addFieldStrategies = $addFieldStrategies;`
`69`	`69`	`$this->addFilterStrategies = $addFilterStrategies;`
`70`	`70`	`$this->modifiersPool = $modifiersPool ?: ObjectManager::getInstance()->get(PoolInterface::class);`
`71`		`- $this->setDefaultStoreToCollection();`
	`71`	`+ $this->getCollection()->setStoreId(Store::DEFAULT_STORE_ID);`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`/**`
`@@ -142,12 +142,4 @@ public function getMeta()`
`142`	`142`
`143`	`143`	`return $meta;`
`144`	`144`	`}`
`145`		`-`
`146`		`- /**`
`147`		`- * Filter the product collection by Default Store if no filter is applied`
`148`		`- */`
`149`		`- private function setDefaultStoreToCollection()`
`150`		`- {`
`151`		`- $this->getCollection()->setStoreId(Store::DEFAULT_STORE_ID);`
`152`		`- }`
`153`	`145`	`}`