GraphQL-87: Fetch attribute values and labels for customAttributeMetadata

Author: Valeriy Nayda

app/code/Magento/EavGraphQl/Model/Resolver/AttributeOptions.php

@@ -7,8 +7,12 @@
 
 namespace Magento\EavGraphQl\Model\Resolver;
 
-use Magento\Eav\Api\AttributeOptionManagementInterface;
+use Magento\EavGraphQl\Model\Resolver\DataProvider\AttributeOptions as AttributeOptionsDataProvider;
+use Magento\Framework\Exception\InputException;
+use Magento\Framework\Exception\StateException;
 use Magento\Framework\GraphQl\Config\Element\Field;
+use Magento\Framework\GraphQl\Exception\GraphQlInputException;
+use Magento\Framework\GraphQl\Exception\GraphQlNoSuchEntityException;
 use Magento\Framework\GraphQl\Query\Resolver\Value;
 use Magento\Framework\GraphQl\Query\Resolver\ValueFactory;
 use Magento\Framework\GraphQl\Query\ResolverInterface;
@@ -20,31 +24,29 @@
 class AttributeOptions implements ResolverInterface
 {
     /**
-     * @var AttributeOptionManagementInterface
+     * @var AttributeOptionsDataProvider
      */
-    protected $optionManager;
+    private $attributeOptionsDataProvider;
 
     /**
-     * @var ValueFactory
+     * @var AttributeOptions
      */
-    protected $valueFactory;
+    private $valueFactory;
 
     /**
-     * AttributeOptions constructor.
-     *
-     * @param AttributeOptionManagementInterface $optionManager
+     * @param AttributeOptionsDataProvider $attributeOptionsDataProvider
      * @param ValueFactory $valueFactory
      */
     public function __construct(
-        AttributeOptionManagementInterface $optionManager,
+        AttributeOptionsDataProvider $attributeOptionsDataProvider,
         ValueFactory $valueFactory
     ) {
-        $this->optionManager = $optionManager;
+        $this->attributeOptionsDataProvider = $attributeOptionsDataProvider;
         $this->valueFactory = $valueFactory;
     }
 
     /**
-     * {@inheritDoc}
+     * @inheritDoc
      */
     public function resolve(
         Field $field,
@@ -53,36 +55,60 @@ public function resolve(
         array $value = null,
         array $args = null
     ) : Value {
-        $options = [];
 
-        $entityType = !empty($value['entity_type']) ? $value['entity_type'] : '';
-        $attributeCode = !empty($value['attribute_code']) ? $value['attribute_code'] : '';
+        return $this->valueFactory->create(function () use ($value) {
+            $entityType = $this->getEntityType($value);
+            $attributeCode = $this->getAttributeCode($value);
 
-        try {
-            /** @var \Magento\Eav\Api\Data\AttributeOptionInterface[] $attributeOptions */
-            $attributeOptions = $this->optionManager->getItems($entityType, $attributeCode);
-        } catch (\Exception $e) {
-            $attributeOptions = [];
+            $optionsData = $this->getAttributeOptionsData($entityType, $attributeCode);
+            return $optionsData;
+        });
+    }
+
+    /**
+     * @param array $value
+     * @return int
+     * @throws GraphQlInputException
+     */
+    private function getEntityType(array $value): int
+    {
+        if (!isset($value['entity_type'])) {
+            throw new GraphQlInputException(__('"Entity type should be specified'));
         }
 
-        if (is_array($attributeOptions)) {
-            /** @var \Magento\Eav\Api\Data\AttributeOptionInterface $option */
-            foreach ($attributeOptions as $option) {
-                if ($option->getValue() === '') {
-                    continue;
-                }
+        return (int)$value['entity_type'];
+    }
 
-                $options[] = [
-                    'label' => $option->getLabel(),
-                    'value' => $option->getValue()
-                ];
-            }
+    /**
+     * @param array $value
+     * @return string
+     * @throws GraphQlInputException
+     */
+    private function getAttributeCode(array $value): string
+    {
+        if (!isset($value['attribute_code'])) {
+            throw new GraphQlInputException(__('"Attribute code should be specified'));
         }
 
-        $result = function () use ($options) {
-            return $options;
-        };
+        return $value['attribute_code'];
+    }
 
-        return $this->valueFactory->create($result);
+    /**
+     * @param int $entityType
+     * @param string $attributeCode
+     * @return array
+     * @throws GraphQlInputException
+     * @throws GraphQlNoSuchEntityException
+     */
+    private function getAttributeOptionsData(int $entityType, string $attributeCode): array
+    {
+        try {
+            $optionsData = $this->attributeOptionsDataProvider->getData($entityType, $attributeCode);
+        } catch (InputException $e) {
+            throw new GraphQlInputException(__($e->getMessage()), $e);
+        } catch (StateException $e) {
+            throw new GraphQlNoSuchEntityException(__($e->getMessage()), $e);
+        }
+        return $optionsData;
     }
 }

app/code/Magento/EavGraphQl/Model/Resolver/DataProvider/AttributeOptions.php

@@ -0,0 +1,54 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\EavGraphQl\Model\Resolver\DataProvider;
+
+use Magento\Eav\Api\AttributeOptionManagementInterface;
+
+/**
+ * Attribute Options data provider
+ */
+class AttributeOptions
+{
+    /**
+     * @var AttributeOptionManagementInterface
+     */
+    private $optionManager;
+
+    /**
+     * @param AttributeOptionManagementInterface $optionManager
+     */
+    public function __construct(
+        AttributeOptionManagementInterface $optionManager
+    ) {
+        $this->optionManager = $optionManager;
+    }
+
+    /**
+     * @param int $entityType
+     * @param string $attributeCode
+     * @return array
+     */
+    public function getData(int $entityType, string $attributeCode): array
+    {
+        $options = $this->optionManager->getItems($entityType, $attributeCode);
+
+        $optionsData = [];
+        foreach ($options as $option) {
+            // without empty option @see \Magento\Eav\Model\Entity\Attribute\Source\Table::getAllOptions
+            if ($option->getValue() === '') {
+                continue;
+            }
+
+            $optionsData[] = [
+                'label' => $option->getLabel(),
+                'value' => $option->getValue()
+            ];
+        }
+        return $optionsData;
+    }
+}