Fix for missed cronjobs history cleanup

Łukasz Olucha · Łukasz Olucha · commit b04cf0e783b0 · 2015-02-19T14:46:50.000+01:00
diff --git a/app/code/Magento/Cron/Model/Observer.php b/app/code/Magento/Cron/Model/Observer.php
@@ -353,7 +353,8 @@ protected function _cleanup($groupId)
         $now = time();
         /** @var Schedule $record */
         foreach ($history as $record) {
-            if (strtotime($record->getExecutedAt()) < $now - $historyLifetimes[$record->getStatus()]) {
+            $checkTime = strtotime($record->getExecutedAt() ? $record->getExecutedAt() : $record->getScheduledAt());
+            if ($checkTime < $now - $historyLifetimes[$record->getStatus()]) {
                 $record->delete();
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -353,7 +353,8 @@ protected function _cleanup($groupId)`
`353`	`353`	`$now = time();`
`354`	`354`	`/** @var Schedule $record */`
`355`	`355`	`foreach ($history as $record) {`
`356`		`- if (strtotime($record->getExecutedAt()) < $now - $historyLifetimes[$record->getStatus()]) {`
	`356`	`+ $checkTime = strtotime($record->getExecutedAt() ? $record->getExecutedAt() : $record->getScheduledAt());`
	`357`	`+ if ($checkTime < $now - $historyLifetimes[$record->getStatus()]) {`
`357`	`358`	`$record->delete();`
`358`	`359`	`}`
`359`	`360`	`}`