MAGETWO-31575: Remove black/white lists from file system and builds configuration

- ObsoleteCodeTest and LiveCodeTest optimized

Author: dkvashninbay

dev/tests/static/framework/Magento/TestFramework/Utility/ChangedFiles.php

@@ -23,21 +23,14 @@ class ChangedFiles
     public static function getPhpFiles($changedFilesList)
     {
         $fileHelper = \Magento\Framework\Test\Utility\Files::init();
-        $allPhpFiles = $fileHelper->getPhpFiles();
         if (isset($_ENV['INCREMENTAL_BUILD'])) {
-            try {
-                $phpFiles = Files::readLists($changedFilesList);
-            } catch (\Exception $e){
-                $phpFiles = [];
+            $phpFiles = Files::readLists($changedFilesList);
+            if (!empty($phpFiles)) {
+                $phpFiles = \Magento\Framework\Test\Utility\Files::composeDataSets($phpFiles);
+                $phpFiles = array_intersect_key($phpFiles, $fileHelper->getPhpFiles());
             }
-
-            foreach ($phpFiles as $key => $phpFile) {
-                $phpFiles[$key] = $fileHelper->getPathToSource() . '/' . $phpFile;
-            }
-            $phpFiles = \Magento\Framework\Test\Utility\Files::composeDataSets($phpFiles);
-            $phpFiles = array_intersect_key($phpFiles, $allPhpFiles);
         } else {
-            $phpFiles = $allPhpFiles;
+            $phpFiles = $fileHelper->getPhpFiles();
         }
 
         return $phpFiles;

dev/tests/static/testsuite/Magento/Test/Legacy/ObsoleteCodeTest.php

@@ -129,7 +129,7 @@ function ($file) {
                 $this->_testObsoleteConstants($content);
                 $this->_testObsoletePropertySkipCalculate($content);
             },
-            \Magento\TestFramework\Utility\ChangedFiles::getPhpFiles(__DIR__ . '/_files/changed_files')
+            \Magento\TestFramework\Utility\ChangedFiles::getPhpFiles(__DIR__ . '/_files/changed_files*')
         );
     }
 

dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php

@@ -52,21 +52,17 @@ public static function getWhitelist($fileTypes = ['php'])
     {
         $directoriesToCheck = file(__DIR__ . '/_files/whitelist/common.txt', FILE_IGNORE_NEW_LINES);
 
-        try {
-            $changedFiles = array_filter(
-                Utility\Files::readLists(__DIR__ . '/_files/changed_files'),
-                function ($path) use ($directoriesToCheck) {
-                    foreach ($directoriesToCheck as $directory) {
-                        if (strpos($path, BP . '/' . $directory) === 0) {
-                            return true;
-                        }
+        $changedFiles = array_filter(
+            Utility\Files::readLists(__DIR__ . '/_files/changed_files*'),
+            function ($path) use ($directoriesToCheck) {
+                foreach ($directoriesToCheck as $directory) {
+                    if (strpos($path, BP . '/' . $directory) === 0) {
+                        return true;
                     }
-                    return false;
                 }
-            );
-        } catch (\Exception $e) {
-            $changedFiles = [];
-        }
+                return false;
+            }
+        );
 
         if (!empty($fileTypes)) {
             $changedFiles = array_filter(

lib/internal/Magento/Framework/Test/Utility/Files.php

@@ -1068,7 +1068,7 @@ public static function readLists($globPattern)
              */
             $files = glob(self::init()->getPathToSource() . '/' . $pattern, GLOB_BRACE);
             if (empty($files)) {
-                throw new \Exception("The glob() pattern '{$pattern}' didn't return any result.");
+                continue;
             }
             $result = array_merge($result, $files);
         }