ENGCOM-6251: Fix minicart promotion region not rendering #25373 #25375

Author: VladimirZaets

app/code/Magento/Catalog/view/base/web/template/product/list/listing.html

@@ -25,15 +25,15 @@
                                 <render args="$col.getBody()"/>
                             </fastForEach>
 
-                            <div if="getRegion('action-primary-area')().length || getRegion('action-secondary-area')().length"
+                            <div if="regionHasElements('action-primary-area') || regionHasElements('action-secondary-area')"
                                  class="product-item-actions">
-                                <div class="actions-primary" if="getRegion('action-primary-area')().length">
+                                <div class="actions-primary" if="regionHasElements('action-primary-area')">
                                     <fastForEach args="data: getRegion('action-primary-area'), as: '$col'" >
                                         <render args="$col.getBody()"/>
                                     </fastForEach>
                                 </div>
 
-                                <div if="getRegion('action-secondary-area')().length"
+                                <div if="regionHasElements('action-secondary-area')"
                                      class="actions-secondary"
                                      data-role="add-to-links">
                                     <fastForEach args="data: getRegion('action-secondary-area'), as: '$col'" >
@@ -42,7 +42,7 @@
                                 </div>
                             </div>
 
-                            <div if="getRegion('description-area')().length"
+                            <div if="regionHasElements('description-area')"
                                  class="product-item-description">
                                 <fastForEach args="data: getRegion('description-area'), as: '$col'" >
                                     <render args="$col.getBody()"/>
@@ -54,4 +54,4 @@
             </ol>
         </div>
     </div>
-</div>
+</div>

app/code/Magento/Checkout/view/frontend/web/js/view/minicart.js

@@ -162,10 +162,11 @@ define([
 
         /**
          * Get cart param by name.
+         *
          * @param {String} name
          * @returns {*}
          */
-        getCartParam: function (name) {
+        getCartParamUnsanitizedHtml: function (name) {
             if (!_.isUndefined(name)) {
                 if (!this.cart.hasOwnProperty(name)) {
                     this.cart[name] = ko.observable();
@@ -175,12 +176,21 @@ define([
             return this.cart[name]();
         },
 
+        /**
+         * @deprecated please use getCartParamUnsanitizedHtml.
+         * @param {String} name
+         * @returns {*}
+         */
+        getCartParam: function (name) {
+            return this.getCartParamUnsanitizedHtml(name);
+        },
+
         /**
          * Returns array of cart items, limited by 'maxItemsToDisplay' setting
          * @returns []
          */
         getCartItems: function () {
-            var items = this.getCartParam('items') || [];
+            var items = this.getCartParamUnsanitizedHtml('items') || [];
 
             items = items.slice(parseInt(-this.maxItemsToDisplay, 10));
 
@@ -192,7 +202,7 @@ define([
          * @returns {Number}
          */
         getCartLineItemsCount: function () {
-            var items = this.getCartParam('items') || [];
+            var items = this.getCartParamUnsanitizedHtml('items') || [];
 
             return parseInt(items.length, 10);
         }

app/code/Magento/Checkout/view/frontend/web/js/view/payment/list.js

@@ -203,7 +203,7 @@ define([
          */
         isPaymentMethodsAvailable: function () {
             return _.some(this.paymentGroupsList(), function (group) {
-                return this.getRegion(group.displayArea)().length;
+                return this.regionHasElements(group.displayArea);
             }, this);
         },
 

app/code/Magento/Checkout/view/frontend/web/template/minicart/content.html

@@ -56,7 +56,7 @@
                         "
                         translate="'Proceed to Checkout'"
                 />
-                <div data-bind="html: getCartParam('extra_actions')"></div>
+                <div data-bind="html: getCartParamUnsanitizedHtml('extra_actions')"></div>
             </div>
         </div>
     </if>
@@ -97,7 +97,7 @@
         </div>
     </div>
 
-    <div id="minicart-widgets" class="minicart-widgets" if="getRegion('promotion').length">
+    <div id="minicart-widgets" class="minicart-widgets" if="regionHasElements('promotion')">
         <each args="getRegion('promotion')" render=""/>
     </div>
 </div>

app/code/Magento/Checkout/view/frontend/web/template/payment-methods/list.html

@@ -8,7 +8,7 @@
      class="items payment-methods">
     <div repeat="foreach: paymentGroupsList, item: '$group'"
          class="payment-group">
-        <div if="getRegion($group().displayArea)().length"
+        <div if="regionHasElements($group().displayArea)"
              translate="getGroupTitle($group)"
              class="step-title"
              data-role="title">

app/code/Magento/Ui/view/base/web/js/lib/core/collection.js

@@ -214,6 +214,19 @@ define([
             return regions[name];
         },
 
+        /**
+         * Checks if the specified region has any elements
+         * associated with it.
+         *
+         * @param {String} name
+         * @returns {Boolean}
+         */
+        regionHasElements: function (name) {
+            var region = this.getRegion(name);
+
+            return region().length > 0;
+        },
+
         /**
          * Replaces specified regions' data with a provided one.
          * Creates region if it was not created yet.