Skip to content

Commit b4171a1

Browse files
committed
Add missing property, fixed incorrect proprty type, add missing throws to PHPDocs
1 parent 6103b6b commit b4171a1

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

app/code/Magento/Ui/Model/Export/ConvertToCsv.php

+9-1
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,10 @@
66
namespace Magento\Ui\Model\Export;
77

88
use Magento\Framework\App\Filesystem\DirectoryList;
9+
use Magento\Framework\Exception\FileSystemException;
910
use Magento\Framework\Exception\LocalizedException;
1011
use Magento\Framework\Filesystem;
12+
use Magento\Framework\Filesystem\Directory\WriteInterface;
1113
use Magento\Ui\Component\MassAction\Filter;
1214

1315
/**
@@ -16,7 +18,7 @@
1618
class ConvertToCsv
1719
{
1820
/**
19-
* @var DirectoryList
21+
* @var WriteInterface
2022
*/
2123
protected $directory;
2224

@@ -30,11 +32,17 @@ class ConvertToCsv
3032
*/
3133
protected $pageSize = null;
3234

35+
/**
36+
* @var Filter
37+
*/
38+
protected $filter;
39+
3340
/**
3441
* @param Filesystem $filesystem
3542
* @param Filter $filter
3643
* @param MetadataProvider $metadataProvider
3744
* @param int $pageSize
45+
* @throws FileSystemException
3846
*/
3947
public function __construct(
4048
Filesystem $filesystem,

app/code/Magento/Ui/Model/Export/ConvertToXml.php

+11-1
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@
1010
use Magento\Framework\App\Filesystem\DirectoryList;
1111
use Magento\Framework\Convert\Excel;
1212
use Magento\Framework\Convert\ExcelFactory;
13+
use Magento\Framework\Exception\FileSystemException;
1314
use Magento\Framework\Exception\LocalizedException;
1415
use Magento\Framework\Filesystem;
16+
use Magento\Framework\Filesystem\Directory\WriteInterface;
1517
use Magento\Ui\Component\MassAction\Filter;
1618

1719
/**
@@ -20,7 +22,7 @@
2022
class ConvertToXml
2123
{
2224
/**
23-
* @var DirectoryList
25+
* @var WriteInterface
2426
*/
2527
protected $directory;
2628

@@ -49,12 +51,18 @@ class ConvertToXml
4951
*/
5052
protected $fields;
5153

54+
/**
55+
* @var Filter
56+
*/
57+
protected $filter;
58+
5259
/**
5360
* @param Filesystem $filesystem
5461
* @param Filter $filter
5562
* @param MetadataProvider $metadataProvider
5663
* @param ExcelFactory $excelFactory
5764
* @param SearchResultIteratorFactory $iteratorFactory
65+
* @throws FileSystemException
5866
*/
5967
public function __construct(
6068
Filesystem $filesystem,
@@ -87,6 +95,7 @@ protected function getOptions()
8795
* Returns DB fields list
8896
*
8997
* @return array
98+
* @throws LocalizedException
9099
*/
91100
protected function getFields()
92101
{
@@ -102,6 +111,7 @@ protected function getFields()
102111
*
103112
* @param DocumentInterface $document
104113
* @return array
114+
* @throws LocalizedException
105115
*/
106116
public function getRowData(DocumentInterface $document)
107117
{

0 commit comments

Comments
 (0)