Skip to content

Commit b76ddf8

Browse files
committed
fix: set message-success in setup if we already have the latest version
1 parent 98e4a6e commit b76ddf8

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

setup/pub/magento/setup/select-version.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ angular.module('select-version', ['ngStorage'])
1313
$scope.upgradeReadyForNext = false;
1414
$scope.upgradeProcessed = false;
1515
$scope.upgradeProcessError = false;
16+
$scope.upgradeAlreadyLatestVersion = false;
1617
$scope.upgradeProcessErrorMessage = '';
1718
$scope.componentsReadyForNext = true;
1819
$scope.componentsProcessed = false;
@@ -39,6 +40,7 @@ angular.module('select-version', ['ngStorage'])
3940

4041
if ($scope.upgradeProcessError) {
4142
$scope.upgradeProcessErrorMessage = "You're already using the latest version, there's nothing for us to do.";
43+
$scope.upgradeAlreadyLatestVersion = true;
4244
} else {
4345
$scope.selectedOption = [];
4446
$scope.versions = [];

setup/view/magento/setup/select-version.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
</span>
3939
<span class="message-text">Checking for a new version...</span>
4040
</div>
41-
<div class="message message-error" ng-show="upgradeProcessError">
41+
<div class="message" ng-class="upgradeAlreadyLatestVersion ? 'message-success' : 'message-error'" ng-show="upgradeProcessError">
4242
<span class="message-text" ng-bind-html="upgradeProcessErrorMessage"></span>
4343
</div>
4444
<div class="message" ng-show="upgradeProcessed && !upgradeProcessError && currentVersion">

0 commit comments

Comments
 (0)