magento/magento2#: GraphQL. Mutation: sendEmailToFriend. Test coverage for “Please provide Email of sender.”

Author: atwixfirster

dev/tests/api-functional/testsuite/Magento/GraphQl/SendFriend/SendFriendTest.php

@@ -287,81 +287,124 @@ public function testSendProductWithoutVisibility()
     /**
      * @return array
      */
-    public function sendFriendsErrorsDataProvider()
+    public function sendFriendsErrorsDataProvider(): array
+    {
+        return array_merge(
+            $this->getRecipientErrors(),
+            $this->getSenderErrors()
+        );
+    }
+
+    /**
+     * @return array
+     */
+    private function getRecipientErrors(): array
     {
         return [
             [
-          'product_id: 1
-         sender: {
-            name: "Name"
-            email: "[email protected]"
-            message: "Lorem Ipsum"
-        }
-          recipients: [
-              {
-                  name: ""
-                  email:"[email protected]"
-               },
-              {
-                  name: ""
-                  email:"[email protected]"
-              }
-          ]', 'Please provide Name for all of recipients.'
+                'product_id: 1
+                sender: {
+                    name: "Name"
+                    email: "[email protected]"
+                    message: "Lorem Ipsum"
+                }
+                recipients: [
+                    {
+                        name: ""
+                        email:"[email protected]"
+                    },
+                    {
+                        name: ""
+                        email:"[email protected]"
+                    }
+                ]',
+                'Please provide Name for all of recipients.'
             ],
             [
                 'product_id: 1
-          sender: {
-            name: "Name"
-            email: "[email protected]"
-            message: "Lorem Ipsum"
-        }
-          recipients: [
-              {
-                  name: "Recipient Name 1"
-                  email:""
-               },
-              {
-                  name: "Recipient Name 2"
-                  email:""
-              }
-          ]', 'Please provide Email for all of recipients.'
+                sender: {
+                    name: "Name"
+                    email: "[email protected]"
+                    message: "Lorem Ipsum"
+                }
+                recipients: [
+                    {
+                        name: "Recipient Name 1"
+                        email:""
+                    },
+                    {
+                       name: "Recipient Name 2"
+                       email:""
+                    }
+                ]',
+                'Please provide Email for all of recipients.'
             ],
+        ];
+    }
+
+    /**
+     * @return array
+     */
+    private function getSenderErrors(): array
+    {
+        return [
             [
                 'product_id: 1
-          sender: {
-            name: ""
-            email: "[email protected]"
-            message: "Lorem Ipsum"
-        }
-          recipients: [
-              {
-                  name: "Recipient Name 1"
-                  email:"[email protected]"
-               },
-              {
-                  name: "Recipient Name 2"
-                  email:"[email protected]"
-              }
-          ]', 'Please provide Name of sender.'
+                sender: {
+                    name: ""
+                    email: "[email protected]"
+                    message: "Lorem Ipsum"
+                }
+                recipients: [
+                    {
+                        name: "Recipient Name 1"
+                        email:"[email protected]"
+                    },
+                    {
+                        name: "Recipient Name 2"
+                        email:"[email protected]"
+                    }
+                ]',
+                'Please provide Name of sender.'
             ],
             [
                 'product_id: 1
-          sender: {
-            name: "Name"
-            email: "[email protected]"
-            message: ""
-        }
-          recipients: [
-              {
-                  name: "Recipient Name 1"
-                  email:"[email protected]"
-               },
-              {
-                  name: "Recipient Name 2"
-                  email:"[email protected]"
-              }
-          ]', 'Please provide Message.'
-            ]
+                sender: {
+                    name: "Name"
+                    email: ""
+                    message: "Lorem Ipsum"
+                }
+                recipients: [
+                    {
+                        name: "Recipient Name 1"
+                        email:"[email protected]"
+                    },
+                    {
+                        name: "Recipient Name 2"
+                        email:"[email protected]"
+                    }
+                ]',
+                'Please provide Email of sender.'
+            ],
+            [
+                'product_id: 1
+                sender: {
+                    name: "Name"
+                    email: "[email protected]"
+                    message: ""
+                }
+                recipients: [
+                    {
+                        name: "Recipient Name 1"
+                        email:"[email protected]"
+                    },
+                    {
+                        name: "Recipient Name 2"
+                        email:"[email protected]"
+                    }
+                ]',
+                'Please provide Message.'
+            ],
         ];
     }