Skip to content

Commit bce4a8c

Browse files
committed
fixed static issue
1 parent 4666ac0 commit bce4a8c

File tree

5 files changed

+19
-18
lines changed

5 files changed

+19
-18
lines changed

app/code/Magento/AdvancedPricingImportExport/Model/Export/AdvancedPricing.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -514,6 +514,7 @@ private function fetchTierPrices(array $productIds): array
514514
*/
515515
protected function getTierPrices(array $listSku, $table)
516516
{
517+
$selectFields = [];
517518
if (isset($this->_parameters[\Magento\ImportExport\Model\Export::FILTER_ELEMENT_GROUP])) {
518519
$exportFilter = $this->_parameters[\Magento\ImportExport\Model\Export::FILTER_ELEMENT_GROUP];
519520
}
@@ -570,12 +571,11 @@ protected function getTierPrices(array $listSku, $table)
570571
if (isset($updatedAtTo) && !empty($updatedAtTo)) {
571572
$select->where('cpe.updated_at <= ?', $updatedAtTo);
572573
}
573-
$exportData = $this->_connection->fetchAll($select);
574+
return $this->_connection->fetchAll($select);
574575
} catch (\Exception $e) {
575576
return false;
576577
}
577578
}
578-
return $exportData;
579579
}
580580

581581
/**

app/code/Magento/Authorization/Setup/Patch/Data/InitializeAuthRoles.php

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66

77
namespace Magento\Authorization\Setup\Patch\Data;
88

9-
use Magento\Authorization\Model\ResourceModel\Role;
10-
use Magento\Authorization\Model\Rules;
11-
use Magento\Authorization\Setup\AuthorizationFactory;
129
use Magento\Framework\App\ResourceConnection;
1310
use Magento\Framework\Setup\ModuleDataSetupInterface;
1411
use Magento\Framework\Setup\Patch\DataPatchInterface;
@@ -17,7 +14,8 @@
1714
use Magento\Authorization\Model\UserContextInterface;
1815

1916
/**
20-
* Class for Initialize Auth Roles
17+
* Class InitializeAuthRoles
18+
* @package Magento\Authorization\Setup\Patch
2119
*/
2220
class InitializeAuthRoles implements DataPatchInterface, PatchVersionInterface
2321
{
@@ -27,24 +25,25 @@ class InitializeAuthRoles implements DataPatchInterface, PatchVersionInterface
2725
private $moduleDataSetup;
2826

2927
/**
30-
* @var AuthorizationFactory
28+
* @var \Magento\Authorization\Setup\AuthorizationFactor
3129
*/
3230
private $authFactory;
3331

3432
/**
33+
* InitializeAuthRoles constructor.
3534
* @param ModuleDataSetupInterface $moduleDataSetup
36-
* @param AuthorizationFactory $authorizationFactory
35+
* @param \Magento\Authorization\Setup\AuthorizationFactor $authorizationFactory
3736
*/
3837
public function __construct(
3938
ModuleDataSetupInterface $moduleDataSetup,
40-
AuthorizationFactory $authorizationFactory
39+
\Magento\Authorization\Setup\AuthorizationFactor $authorizationFactory
4140
) {
4241
$this->moduleDataSetup = $moduleDataSetup;
4342
$this->authFactory = $authorizationFactory;
4443
}
4544

4645
/**
47-
* @inheritdoc
46+
* {@inheritdoc}
4847
*/
4948
public function apply()
5049
{
@@ -69,7 +68,7 @@ public function apply()
6968
]
7069
)->save();
7170
} else {
72-
/** @var Role $item */
71+
/** @var \Magento\Authorization\Model\ResourceModel\Role $item */
7372
foreach ($roleCollection as $item) {
7473
$admGroupRole = $item;
7574
break;
@@ -90,7 +89,7 @@ public function apply()
9089
]
9190
)->save();
9291
} else {
93-
/** @var Rules $rule */
92+
/** @var \Magento\Authorization\Model\Rules $rule */
9493
foreach ($rulesCollection as $rule) {
9594
$rule->setData('resource_id', 'Magento_Backend::all')->save();
9695
}
@@ -109,23 +108,23 @@ public function apply()
109108
}
110109

111110
/**
112-
* @inheritdoc
111+
* {@inheritdoc}
113112
*/
114113
public static function getDependencies()
115114
{
116115
return [];
117116
}
118117

119118
/**
120-
* @inheritdoc
119+
* {@inheritdoc}
121120
*/
122121
public static function getVersion()
123122
{
124123
return '2.0.0';
125124
}
126125

127126
/**
128-
* @inheritdoc
127+
* {@inheritdoc}
129128
*/
130129
public function getAliases()
131130
{

app/code/Magento/CatalogInventory/Model/Indexer/Stock/AbstractAction.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212

1313
/**
1414
* Abstract action reindex class
15-
*
16-
* @package Magento\CatalogInventory\Model\Indexer\Stock
1715
*/
1816
abstract class AbstractAction
1917
{
@@ -281,6 +279,8 @@ private function doReindex($productIds = [])
281279
}
282280

283281
/**
282+
* Get cache cleaner object
283+
*
284284
* @return CacheCleaner
285285
*/
286286
private function getCacheCleaner()

app/code/Magento/CatalogInventory/Model/Indexer/Stock/Action/Full.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22
/**
3+
* @category Magento
4+
* @package Magento_CatalogInventory
35
* Copyright © Magento, Inc. All rights reserved.
46
* See COPYING.txt for license details.
57
*/

app/code/Magento/CatalogInventory/Model/Indexer/Stock/Processor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
class Processor extends \Magento\Framework\Indexer\AbstractProcessor
1010
{
1111
/**
12-
* Indexer ID
12+
* Get Indexer ID for cataloginventory_stock
1313
*/
1414
const INDEXER_ID = 'cataloginventory_stock';
1515
}

0 commit comments

Comments
 (0)