Skip to content

Commit bd4ea02

Browse files
karyna-tandrewbess
authored andcommitted
Added fixes for static tests found on platform health
1 parent d8309f1 commit bd4ea02

File tree

3 files changed

+8
-15
lines changed

3 files changed

+8
-15
lines changed

app/code/Magento/Backend/Block/Widget/Grid/Column.php

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
67
namespace Magento\Backend\Block\Widget\Grid;
78

89
use Magento\Backend\Block\Widget;
@@ -46,7 +47,7 @@ class Column extends Widget
4647
protected $_cssClass = null;
4748

4849
/**
49-
* Renderer types
50+
* The renderer types
5051
*
5152
* @var array
5253
*/
@@ -74,7 +75,7 @@ class Column extends Widget
7475
];
7576

7677
/**
77-
* Filter types
78+
* The filter types
7879
*
7980
* @var array
8081
*/
@@ -422,11 +423,7 @@ public function setRendererType($type, $className)
422423
protected function _getRendererByType()
423424
{
424425
$type = strtolower((string) $this->getType());
425-
$rendererClass = isset(
426-
$this->_rendererTypes[$type]
427-
) ? $this->_rendererTypes[$type] : $this->_rendererTypes['default'];
428-
429-
return $rendererClass;
426+
return $this->_rendererTypes[$type] ?? $this->_rendererTypes['default'];
430427
}
431428

432429
/**
@@ -479,9 +476,7 @@ public function setFilterType($type, $className)
479476
protected function _getFilterByType()
480477
{
481478
$type = $this->getFilterType() ? strtolower($this->getFilterType()) : strtolower((string) $this->getType());
482-
$filterClass = isset($this->_filterTypes[$type]) ? $this->_filterTypes[$type] : $this->_filterTypes['default'];
483-
484-
return $filterClass;
479+
return $this->_filterTypes[$type] ?? $this->_filterTypes['default'];
485480
}
486481

487482
/**

app/code/Magento/Reports/Model/ResourceModel/Order/Collection.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,29 +3,27 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
67
namespace Magento\Reports\Model\ResourceModel\Order;
78

89
use Magento\Framework\DB\Select;
910

1011
/**
1112
* Reports orders collection
1213
*
13-
* @author Magento Core Team <[email protected]>
1414
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
1515
* @api
1616
* @since 100.0.2
1717
*/
1818
class Collection extends \Magento\Sales\Model\ResourceModel\Order\Collection
1919
{
2020
/**
21-
* Is live
22-
*
2321
* @var bool
2422
*/
2523
protected $_isLive = false;
2624

2725
/**
28-
* Sales amount expression
26+
* The sales amount expression
2927
*
3028
* @var string
3129
*/

app/code/Magento/Usps/Model/Carrier.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C
109109
protected $_customizableContainerTypes = ['VARIABLE', 'RECTANGULAR', 'NONRECTANGULAR'];
110110

111111
/**
112-
* Carrier helper
112+
* The carrier helper
113113
*
114114
* @var \Magento\Shipping\Helper\Carrier
115115
*/

0 commit comments

Comments
 (0)