Skip to content

Commit bf58c53

Browse files
🔃 [EngCom] Public Pull Requests - 2.1-develop
Accepted Public Pull Requests: - #16835: [Backport] Smallest codestyle fix in Option/Type/Text.php (by @mage2pratik) - #16828: [Backport] FIX for apparently random API failures while using array types (by @ronak2ram) - #16802: [Backport] #16685 Updated security issues details (by @quisse)
2 parents a160f2b + 39d057e commit bf58c53

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ Magento is thankful for any contribution that can improve our code base, documen
8989

9090
<h2>Reporting security issues</h2>
9191

92-
To report security vulnerabilities in Magento software or web sites, please e-mail <a href="mailto:[email protected]">[email protected]</a>. Please do not report security issues using GitHub. Be sure to encrypt your e-mail with our <a href="https://info2.magento.com/rs/magentoenterprise/images/security_at_magento.asc">encryption key</a> if it includes sensitive information. Learn more about reporting security issues <a href="https://magento.com/security/reporting-magento-security-issue">here</a>.
92+
To report security vulnerabilities in Magento software or web sites, please create a Bugcrowd researcher account <a href="https://bugcrowd.com/magento">there</a> to submit and follow-up your issue. Learn more about reporting security issues <a href="https://magento.com/security/reporting-magento-security-issue">here</a>.
9393

9494
Stay up-to-date on the latest vulnerabilities and patches for Magento by signing up for <a href="https://magento.com/security/sign-up">Security Alert Notifications</a>.
9595

app/code/Magento/Catalog/Model/Product/Option/Type/Text.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public function validateUserValue($values)
8181
*/
8282
public function prepareForCart()
8383
{
84-
if ($this->getIsValid() && strlen($this->getUserValue()) > 0) {
84+
if ($this->getIsValid() && ($this->getUserValue() !== '')) {
8585
return $this->getUserValue();
8686
} else {
8787
return null;

lib/internal/Magento/Framework/Reflection/TypeProcessor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -555,7 +555,7 @@ public function getParamType(ParameterReflection $param)
555555
if ($type == 'array') {
556556
// try to determine class, if it's array of objects
557557
$docBlock = $param->getDeclaringFunction()->getDocBlock();
558-
$pattern = "/\@param\s+([\w\\\_]+\[\])\s+\\\${$param->getName()}\n/";
558+
$pattern = "/\@param\s+([\w\\\_]+\[\])\s+\\\${$param->getName()}[\n\r]/";
559559
$matches = [];
560560
if (preg_match($pattern, $docBlock->getContents(), $matches)) {
561561
return $matches[1];

0 commit comments

Comments
 (0)