Skip to content

Commit ca543eb

Browse files
Patch to allow multiple filter_url_params to function
Multiple filter_url_params in UI_component will fail due to missing / separator in sprintf function. Otherwise the 2nd url parameter will be compiled into the value of the first parameter such as SKU/12345pr/ when in fact the second variable passed was PR/PULLREQUEST/ as part of SKU/12345/pr/PULLREQUEST! Only happens when you pass multiple variables to in ui_component such as ` <argument name="data" xsi:type="array"> <item name="config" xsi:type="array"> <item name="update_url" xsi:type="url" path="mui/index/render"/> <item name="filter_url_params" xsi:type="array"> <item name="customer_number" xsi:type="string">*</item> <item name="sku" xsi:type="string">*</item> </item> </item> </argument> `
1 parent bdb0464 commit ca543eb

File tree

1 file changed

+1
-1
lines changed
  • lib/internal/Magento/Framework/View/Element/UiComponent/DataProvider

1 file changed

+1
-1
lines changed

lib/internal/Magento/Framework/View/Element/UiComponent/DataProvider/DataProvider.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ protected function prepareUpdateUrl()
123123
}
124124
if ($paramValue) {
125125
$this->data['config']['update_url'] = sprintf(
126-
'%s%s/%s',
126+
'%s%s/%s/',
127127
$this->data['config']['update_url'],
128128
$paramName,
129129
$paramValue

0 commit comments

Comments
 (0)