Merge remote-tracking branch 'tango/MC-33512' into Chaika-PR-2020-05-21

Author: veloraven

dev/tests/api-functional/testsuite/Magento/Catalog/Api/SpecialPriceStorageTest.php

@@ -5,20 +5,28 @@
  */
 namespace Magento\Catalog\Api;
 
+use Magento\Catalog\Api\Data\ProductInterface;
+use Magento\Framework\Exception\CouldNotSaveException;
+use Magento\Framework\Exception\InputException;
+use Magento\Framework\Exception\NoSuchEntityException;
+use Magento\Framework\Exception\StateException;
+use Magento\Framework\Webapi\Rest\Request;
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\TestFramework\ObjectManager;
 use Magento\TestFramework\TestCase\WebapiAbstract;
-use Magento\Framework\Webapi\Exception as HTTPExceptionCodes;
 
 /**
- * SpecialPriceStorage test.
+ * SpecialPriceStorage API operations test
  */
 class SpecialPriceStorageTest extends WebapiAbstract
 {
     const SERVICE_NAME = 'catalogSpecialPriceStorageV1';
     const SERVICE_VERSION = 'V1';
     const SIMPLE_PRODUCT_SKU = 'simple';
+    const VIRTUAL_PRODUCT_SKU = 'virtual-product';
 
     /**
-     * @var \Magento\TestFramework\ObjectManager
+     * @var ObjectManager
      */
     private $objectManager;
 
@@ -27,7 +35,7 @@ class SpecialPriceStorageTest extends WebapiAbstract
      */
     protected function setUp()
     {
-        $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+        $this->objectManager = Bootstrap::getObjectManager();
     }
 
     /**
@@ -38,14 +46,14 @@ protected function setUp()
     public function testGet()
     {
         $specialPrice = 3057;
-        $productRepository = $this->objectManager->create(\Magento\Catalog\Api\ProductRepositoryInterface::class);
+        $productRepository = $this->objectManager->create(ProductRepositoryInterface::class);
         $product = $productRepository->get(self::SIMPLE_PRODUCT_SKU, true);
         $product->setData('special_price', $specialPrice);
         $productRepository->save($product);
         $serviceInfo = [
             'rest' => [
                 'resourcePath' => '/V1/products/special-price-information',
-                'httpMethod' => \Magento\Framework\Webapi\Rest\Request::HTTP_METHOD_POST
+                'httpMethod' => Request::HTTP_METHOD_POST
             ],
             'soap' => [
                 'service' => self::SERVICE_NAME,
@@ -54,7 +62,7 @@ public function testGet()
             ],
         ];
         $response = $this->_webApiCall($serviceInfo, ['skus' => [self::SIMPLE_PRODUCT_SKU]]);
-        /** @var \Magento\Catalog\Api\Data\ProductInterface $product */
+        /** @var ProductInterface $product */
         $product = $productRepository->get(self::SIMPLE_PRODUCT_SKU);
         $this->assertNotEmpty($response);
         $this->assertEquals($product->getSpecialPrice(), $response[0]['price']);
@@ -64,34 +72,27 @@ public function testGet()
      * Test update method.
      *
      * @magentoApiDataFixture Magento/Catalog/_files/product_virtual.php
+     * @dataProvider updateData
+     * @param array $data
      */
-    public function testUpdate()
+    public function testUpdate(array $data)
     {
-        $sku = 'virtual-product';
         $serviceInfo = [
             'rest' => [
                 'resourcePath' => '/V1/products/special-price',
-                'httpMethod' => \Magento\Framework\Webapi\Rest\Request::HTTP_METHOD_POST
+                'httpMethod' => Request::HTTP_METHOD_POST
             ],
             'soap' => [
                 'service' => self::SERVICE_NAME,
                 'serviceVersion' => self::SERVICE_VERSION,
                 'operation' => self::SERVICE_NAME . 'Update',
             ],
         ];
-        $storeId = 0;
-        $newPrice = 31337;
         $response = $this->_webApiCall(
             $serviceInfo,
             [
                 'prices' => [
-                    [
-                        'price' => $newPrice,
-                        'store_id' => $storeId,
-                        'sku' => $sku,
-                        'price_from' => '2037-01-19 03:14:07',
-                        'price_to' => '2038-01-19 03:14:07',
-                    ]
+                    $data
                 ]
             ]
         );
@@ -102,23 +103,28 @@ public function testUpdate()
      * Test delete method.
      *
      * @magentoApiDataFixture Magento/Catalog/_files/product_simple.php
+     * @dataProvider deleteData
+     * @param array $data
+     * @throws CouldNotSaveException
+     * @throws InputException
+     * @throws NoSuchEntityException
+     * @throws StateException
      */
-    public function testDelete()
+    public function testDelete(array $data)
     {
-        $specialPrice = 3057;
-        /** @var \Magento\Catalog\Api\ProductRepositoryInterface $productRepository */
-        $productRepository = $this->objectManager->create(\Magento\Catalog\Api\ProductRepositoryInterface::class);
-        $fromDate = '1970-01-01 00:00:01';
-        $toDate = '2038-01-19 03:14:07';
-        $product = $productRepository->get(self::SIMPLE_PRODUCT_SKU, true);
-        $product->setData('special_price', $specialPrice)
-            ->setData('special_from_date', $fromDate)
-            ->setData('special_to_date', $toDate);
+        /** @var ProductRepositoryInterface $productRepository */
+        $productRepository = $this->objectManager->create(ProductRepositoryInterface::class);
+        $product = $productRepository->get($data['sku'], true);
+        $product->setData('special_price', $data['price']);
+        $product->setData('special_from_date', $data['price_from']);
+        if ($data['price_to']) {
+            $product->setData('special_to_date', $data['price_to']);
+        }
         $productRepository->save($product);
         $serviceInfo = [
             'rest' => [
                 'resourcePath' => '/V1/products/special-price-delete',
-                'httpMethod' => \Magento\Framework\Webapi\Rest\Request::HTTP_METHOD_POST
+                'httpMethod' => Request::HTTP_METHOD_POST
             ],
             'soap' => [
                 'service' => self::SERVICE_NAME,
@@ -130,19 +136,80 @@ public function testDelete()
             $serviceInfo,
             [
                 'prices' => [
-                    [
-                        'price' => $specialPrice,
-                        'store_id' => 0,
-                        'sku' => self::SIMPLE_PRODUCT_SKU,
-                        'price_from' => $fromDate,
-                        'price_to' => $toDate,
-                    ]
+                        $data
                 ]
             ]
         );
-        /** @var \Magento\Catalog\Api\Data\ProductInterface $product */
-        $product = $productRepository->get(self::SIMPLE_PRODUCT_SKU, false, null, true);
+        $product = $productRepository->get($data['sku'], false, null, true);
         $this->assertEmpty($response);
         $this->assertNull($product->getSpecialPrice());
     }
+
+    /**
+     * Data provider for testUpdate
+     *
+     * @return array
+     */
+    public function updateData(): array
+    {
+        $fromDate = '2037-01-19 03:14:07';
+        $toDate = '2038-01-19 03:14:07';
+
+        return [
+            [
+                // data set with 'price_to' specified
+                [
+                    'price' => 31337,
+                    'store_id' => 0,
+                    'sku' => self::VIRTUAL_PRODUCT_SKU,
+                    'price_from' => $fromDate,
+                    'price_to' => $toDate
+                ]
+            ],
+            [
+                // data set without 'price_to' specified
+                [
+                    'price' => 31337,
+                    'store_id' => 0,
+                    'sku' => self::VIRTUAL_PRODUCT_SKU,
+                    'price_from' => $fromDate,
+                    'price_to' => false
+                ]
+            ],
+        ];
+    }
+
+    /**
+     * Data provider for testDelete
+     *
+     * @return array
+     */
+    public function deleteData(): array
+    {
+        $fromDate = '1970-01-01 00:00:01';
+        $toDate = '2038-01-19 03:14:07';
+
+        return [
+            [
+                // data set with 'price_to' specified
+                [
+                    'price' => 3057,
+                    'store_id' => 0,
+                    'sku' => self::SIMPLE_PRODUCT_SKU,
+                    'price_from' => $fromDate,
+                    'price_to' => $toDate
+                ]
+            ],
+            [
+                // data set without 'price_to' specified
+                [
+                    'price' => 3057,
+                    'store_id' => 0,
+                    'sku' => self::SIMPLE_PRODUCT_SKU,
+                    'price_from' => $fromDate,
+                    'price_to' => false
+                ]
+            ],
+        ];
+    }
 }