MAGETWO-81841: Added CLI command to enable and disable the Profiler #11407

 - fixed code style issues

Author: Oleksii Korshenko

app/bootstrap.php

@@ -54,8 +54,12 @@
     && isset($_SERVER['HTTP_ACCEPT'])
     && strpos($_SERVER['HTTP_ACCEPT'], 'text/html') !== false
 ) {
+    $profilerFlag = isset($_SERVER['MAGE_PROFILER']) && strlen($_SERVER['MAGE_PROFILER'])
+        ? $_SERVER['MAGE_PROFILER']
+        : trim(file_get_contents(BP . '/var/profiler.flag'));
+
     \Magento\Framework\Profiler::applyConfig(
-        (isset($_SERVER['MAGE_PROFILER']) && strlen($_SERVER['MAGE_PROFILER'])) ? $_SERVER['MAGE_PROFILER'] : trim(file_get_contents(BP . '/var/profiler.flag')),
+        $profilerFlag,
         BP,
         !empty($_SERVER['HTTP_X_REQUESTED_WITH']) && $_SERVER['HTTP_X_REQUESTED_WITH'] == 'XMLHttpRequest'
     );

app/code/Magento/Developer/Console/Command/ProfilerDisableCommand.php

@@ -11,6 +11,9 @@
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
+/**
+ * CLI Command to disable Magento profiler.
+ */
 class ProfilerDisableCommand extends Command
 {
     /**
@@ -37,11 +40,12 @@ class ProfilerDisableCommand extends Command
      * Initialize dependencies.
      *
      * @param File $filesystem
+     * @param string|null $name The name of the command; passing null means it must be set in configure()
      * @internal param ConfigInterface $resourceConfig
      */
-    public function __construct(File $filesystem)
+    public function __construct(File $filesystem, $name = null)
     {
-        parent::__construct();
+        parent::__construct($name ?: self::COMMAND_NAME);
         $this->filesystem = $filesystem;
     }
 
@@ -50,9 +54,7 @@ public function __construct(File $filesystem)
      */
     protected function configure()
     {
-        $this->setName(self::COMMAND_NAME)
-            ->setDescription('Disable the profiler.');
-
+        $this->setDescription('Disable the profiler.');
         parent::configure();
     }
 

app/code/Magento/Developer/Console/Command/ProfilerEnableCommand.php

@@ -12,6 +12,9 @@
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Input\InputArgument;
 
+/**
+ * CLI Command to enable Magento profiler.
+ */
 class ProfilerEnableCommand extends Command
 {
     /**
@@ -48,11 +51,12 @@ class ProfilerEnableCommand extends Command
      * Initialize dependencies.
      *
      * @param File $filesystem
+     * @param string|null $name The name of the command; passing null means it must be set in configure()
      * @internal param ConfigInterface $resourceConfig
      */
-    public function __construct(File $filesystem)
+    public function __construct(File $filesystem, $name = null)
     {
-        parent::__construct();
+        parent::__construct($name ?: self::COMMAND_NAME);
         $this->filesystem = $filesystem;
     }
 
@@ -61,9 +65,8 @@ public function __construct(File $filesystem)
      */
     protected function configure()
     {
-        $this->setName(self::COMMAND_NAME)
-            ->setDescription('Enable the profiler.')
-            ->addArgument('type', InputArgument::OPTIONAL, 'Profiler type');
+        $this->setDescription('Enable the profiler.')
+            ->addArgument('type', InputArgument::OPTIONAL, 'Profiler type', self::TYPE_DEFAULT);
 
         parent::configure();
     }
@@ -75,10 +78,6 @@ protected function configure()
     protected function execute(InputInterface $input, OutputInterface $output)
     {
         $type = $input->getArgument('type');
-        if (!$type) {
-            $type = self::TYPE_DEFAULT;
-        }
-
         if (!in_array($type, self::BUILT_IN_TYPES)) {
             $builtInTypes = implode(', ', self::BUILT_IN_TYPES);
             $output->writeln(