Optimize modules filtering in Magento\Framework\Module\ModuleList\Loader::load()

andrey-legayev · andrey-legayev · commit d875236dc3cf · 2019-10-09T17:39:23.000+03:00
diff --git a/lib/internal/Magento/Framework/Module/ModuleList/Loader.php b/lib/internal/Magento/Framework/Module/ModuleList/Loader.php
@@ -78,6 +78,8 @@ public function __construct(
     public function load(array $exclude = [])
     {
         $result = [];
+        $excludeSet = array_flip($exclude);
+
         foreach ($this->getModuleConfigs() as list($file, $contents)) {
             try {
                 $this->parser->loadXML($contents);
@@ -93,7 +95,7 @@ public function load(array $exclude = [])
 
             $data = $this->converter->convert($this->parser->getDom());
             $name = key($data);
-            if (!in_array($name, $exclude)) {
+            if (!isset($excludeSet[$name])) {
                 $result[$name] = $data[$name];
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,8 @@ public function __construct(`
`78`	`78`	`public function load(array $exclude = [])`
`79`	`79`	`{`
`80`	`80`	`$result = [];`
	`81`	`+ $excludeSet = array_flip($exclude);`
	`82`	`+`
`81`	`83`	`foreach ($this->getModuleConfigs() as list($file, $contents)) {`
`82`	`84`	`try {`
`83`	`85`	`$this->parser->loadXML($contents);`
`@@ -93,7 +95,7 @@ public function load(array $exclude = [])`
`93`	`95`
`94`	`96`	`$data = $this->converter->convert($this->parser->getDom());`
`95`	`97`	`$name = key($data);`
`96`		`- if (!in_array($name, $exclude)) {`
	`98`	`+ if (!isset($excludeSet[$name])) {`
`97`	`99`	`$result[$name] = $data[$name];`
`98`	`100`	`}`
`99`	`101`	`}`