MC-17633: After running setup:upgrade, setup:db:check still says: Declarative Schema is not up to date (MariaDB issue)

rganin · rganin · commit dbb8472b0af7 · 2019-11-01T13:37:35.000-05:00
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/DefinitionAggregator.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/DefinitionAggregator.php
@@ -109,7 +109,7 @@ protected function processDefaultValue(array $data)
         if ($defaultValue === "'NULL'") {
             return "NULL";
         }
-        if ($defaultValue === "NULL" && (bool) strpos($this->getDatabaseVersion(), 'MariaDB')) {
+        if ($defaultValue === "NULL" && strpos($this->getDatabaseVersion(), 'MariaDB') !== false) {
             return null;
         }
         /*

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ protected function processDefaultValue(array $data)`
`109`	`109`	`if ($defaultValue === "'NULL'") {`
`110`	`110`	`return "NULL";`
`111`	`111`	`}`
`112`		`- if ($defaultValue === "NULL" && (bool) strpos($this->getDatabaseVersion(), 'MariaDB')) {`
	`112`	`+ if ($defaultValue === "NULL" && strpos($this->getDatabaseVersion(), 'MariaDB') !== false) {`
`113`	`113`	`return null;`
`114`	`114`	`}`
`115`	`115`	`/*`