ENGCOM-3615: Log jobCode when writing to log with no callback for easier debug #19541

sidolov · web-flow · commit dbd1680be54b · 2018-12-09T09:51:21.000-06:00
diff --git a/app/code/Magento/Cron/Observer/ProcessCronQueueObserver.php b/app/code/Magento/Cron/Observer/ProcessCronQueueObserver.php
@@ -298,7 +298,7 @@ protected function _runJob($scheduledTime, $currentTime, $jobConfig, $schedule,
 
         if (!isset($jobConfig['instance'], $jobConfig['method'])) {
             $schedule->setStatus(Schedule::STATUS_ERROR);
-            throw new \Exception('No callbacks found');
+            throw new \Exception(sprintf('No callbacks found for cron job %s', $jobCode));
         }
         $model = $this->_objectManager->create($jobConfig['instance']);
         $callback = [$model, $jobConfig['method']];

Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,7 @@ protected function _runJob($scheduledTime, $currentTime, $jobConfig, $schedule,`
`298`	`298`
`299`	`299`	`if (!isset($jobConfig['instance'], $jobConfig['method'])) {`
`300`	`300`	`$schedule->setStatus(Schedule::STATUS_ERROR);`
`301`		`- throw new \Exception('No callbacks found');`
	`301`	`+ throw new \Exception(sprintf('No callbacks found for cron job %s', $jobCode));`
`302`	`302`	`}`
`303`	`303`	`$model = $this->_objectManager->create($jobConfig['instance']);`
`304`	`304`	`$callback = [$model, $jobConfig['method']];`