MAGETWO-67500: setup:di:compile returns exit code 0 if errors are found #7780

Oleksii Korshenko · Oleksii Korshenko · commit e4276a7dd63a · 2017-06-12T11:29:29.000-05:00
- fixed false positive failures
diff --git a/setup/src/Magento/Setup/Module/Di/Compiler/Log/Log.php b/setup/src/Magento/Setup/Module/Di/Compiler/Log/Log.php
@@ -86,7 +86,9 @@ public function report()
     {
         $this->_successWriter->write($this->_successEntries);
         $this->_errorWriter->write($this->_errorEntries);
-        if (count($this->_errorEntries) > 0) {
+        //do not take into account empty items since they are initialized in constructor.
+        $errors = array_filter($this->_errorEntries);
+        if (count($errors) > 0) {
             throw new \Magento\Framework\Validator\Exception(__('Error during compilation'));
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,9 @@ public function report()`
`86`	`86`	`{`
`87`	`87`	`$this->_successWriter->write($this->_successEntries);`
`88`	`88`	`$this->_errorWriter->write($this->_errorEntries);`
`89`		`- if (count($this->_errorEntries) > 0) {`
	`89`	`+ //do not take into account empty items since they are initialized in constructor.`
	`90`	`+ $errors = array_filter($this->_errorEntries);`
	`91`	`+ if (count($errors) > 0) {`
`90`	`92`	`throw new \Magento\Framework\Validator\Exception(__('Error during compilation'));`
`91`	`93`	`}`
`92`	`94`	`}`