Skip to content

Commit e444de6

Browse files
committed
Merge remote-tracking branch '37018/catalog-mftf-cron-run-reliability' into comm_prs_247beta3_dec
2 parents ef65641 + 95c1b1d commit e444de6

File tree

5 files changed

+10
-8
lines changed

5 files changed

+10
-8
lines changed

app/code/Magento/Bundle/Test/Mftf/Test/AdminBundleDynamicAttributesAfterMassUpdateTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
<argument name="consumerName" value="{{AdminProductAttributeUpdateConsumerData.consumerName}}"/>
4848
<argument name="maxMessages" value="{{AdminProductAttributeUpdateConsumerData.messageLimit}}"/>
4949
</actionGroup>
50-
<magentoCron stepKey="runCron"/>
50+
<magentoCron groups="default" stepKey="runCron"/>
5151

5252
<actionGroup ref="OpenProductForEditByClickingRowXColumnYInProductGridActionGroup" stepKey="openProductForEdit"/>
5353

app/code/Magento/Catalog/Test/Mftf/Test/StorefrontVerifyProductAfterPartialReindexOnSeveralWebsitesTest.xml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,11 @@
8787
<argument name="productName" value="{{_defaultProduct.name}}"/>
8888
</actionGroup>
8989

90-
<!-- Run cron -->
91-
<magentoCron stepKey="runCron" />
92-
<magentoCron stepKey="runCronTwice" />
90+
<!-- We need the 'indexer_update_all_views' job to run. This is the best
91+
way we can make that happen, but there is no guarantee that there is
92+
such a job already scheduled in the queue. -->
93+
<magentoCron groups="index" stepKey="runCron" />
94+
<comment userInput="We need the indexer_update_all_views job to run" stepKey="runCronTwice"/>
9395

9496
<!-- Check product is present in category after cron run -->
9597
<actionGroup ref="AssertProductInStorefrontCategoryPage" stepKey="assertProductInStorefront1">

app/code/Magento/SalesRule/Test/Mftf/Test/StorefrontReuseCouponCodeAfterOrderCanceledTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@
9494
<argument name="orderNumberMessage" value="CONST.successCheckoutOrderNumberMessage"/>
9595
<argument name="emailYouMessage" value="CONST.successCheckoutEmailYouMessage"/>
9696
</actionGroup>
97-
<magentoCron stepKey="runCronAfterPlacingOrder"/>
97+
<magentoCron groups="default" stepKey="runCronAfterPlacingOrder"/>
9898

9999
<!-- Get Order id -->
100100
<grabTextFrom selector="{{CheckoutSuccessMainSection.orderNumber22}}" stepKey="grabOrderNumber"/>
@@ -114,7 +114,7 @@
114114
<!-- Cancel order -->
115115
<actionGroup ref="CancelPendingOrderActionGroup" stepKey="cancelOrder"/>
116116
<waitForPageLoad stepKey="waitForOrderDetailsToLoad"/>
117-
<magentoCron stepKey="runCronAfterCancelingOrder"/>
117+
<magentoCron groups="default" stepKey="runCronAfterCancelingOrder"/>
118118

119119
<!-- Open My Account Page from Customer dropdown -->
120120
<actionGroup ref="StorefrontOpenMyAccountPageActionGroup" stepKey="goToMyAccountPage"/>

lib/internal/Magento/Framework/Shell/CommandRendererBackground.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,6 @@ public function render($command, array $arguments = [])
3535

3636
return $this->osInfo->isWindows() ?
3737
'start /B "magento background task" ' . $command
38-
: str_replace('2>&1', '> /dev/null &', $command);
38+
: str_replace('2>&1', '2>/dev/null >/dev/null &', $command);
3939
}
4040
}

lib/internal/Magento/Framework/Shell/Test/Unit/CommandRendererBackgroundTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public function commandPerOsTypeDataProvider()
5959
{
6060
return [
6161
'windows' => [true, 'start /B "magento background task" ' . $this->testCommand . ' 2>&1'],
62-
'unix' => [false, $this->testCommand . ' > /dev/null &'],
62+
'unix' => [false, $this->testCommand . ' 2>/dev/null >/dev/null &'],
6363
];
6464
}
6565
}

0 commit comments

Comments
 (0)