MAGETWO-49460: CartRepositoryInterface can't be used twice

updated fix

Author: Serhiy Shkolyarenko

app/code/Magento/Quote/Model/QuoteRepository.php

@@ -179,22 +179,22 @@ protected function loadQuote($loadMethod, $loadField, $identifier, array $shared
      * Get quote collection
      * Temporary method to support release backward compatibility.
      *
+     * @deprecated
      * @return QuoteCollection
      */
-    protected function resetQuoteCollection()
+    protected function getQuoteCollection()
     {
+        /** @var \Magento\Quote\Model\ResourceModel\Quote\CollectionFactory $collectionFactory */
         $collectionFactory = ObjectManager::getInstance()->get(QuoteCollectionFactory::class);
-        $this->quoteCollection = $collectionFactory->create();
-
-        return $this->quoteCollection;
+        return $collectionFactory->create();
     }
 
     /**
      * {@inheritdoc}
      */
     public function getList(\Magento\Framework\Api\SearchCriteria $searchCriteria)
     {
-        $this->quoteCollection = $this->resetQuoteCollection();
+        $this->quoteCollection = $this->getQuoteCollection();
         /** @var \Magento\Quote\Api\Data\CartSearchResultsInterface $searchData */
         $searchData = $this->searchResultsDataFactory->create();
         $searchData->setSearchCriteria($searchCriteria);

app/code/Magento/Quote/Test/Unit/Model/QuoteRepositoryTest.php

@@ -382,7 +382,7 @@ public function testGetListSuccess($direction, $expectedDirection)
 
         $this->model = $this->getMock(
             'Magento\Quote\Model\QuoteRepository',
-            ['resetQuoteCollection'],
+            ['getQuoteCollection'],
             [
                 'quoteFactory' => $this->quoteFactoryMock,
                 'storeManager' => $this->storeManagerMock,
@@ -391,7 +391,7 @@ public function testGetListSuccess($direction, $expectedDirection)
                 'extensionAttributesJoinProcessor' => $this->extensionAttributesJoinProcessorMock
             ]
         );
-        $this->model->expects($this->once())->method('resetQuoteCollection')->willReturn($this->quoteCollectionMock);
+        $this->model->expects($this->once())->method('getQuoteCollection')->willReturn($this->quoteCollectionMock);
         $this->assertEquals($searchResult, $this->model->getList($searchCriteriaMock));
     }