File tree 3 files changed +46
-2
lines changed
Catalog/view/adminhtml/web/js/components
Ui/view/base/web/js/dynamic-rows
dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/dynamic-rows
3 files changed +46
-2
lines changed Original file line number Diff line number Diff line change @@ -9,6 +9,10 @@ define([
9
9
] , function ( _ , DynamicRows ) {
10
10
'use strict' ;
11
11
12
+ /**
13
+ * @deprecated Parent method contains labels sorting.
14
+ * @see Magento_Ui/js/dynamic-rows/dynamic-rows
15
+ */
12
16
return DynamicRows . extend ( {
13
17
14
18
/**
Original file line number Diff line number Diff line change @@ -533,7 +533,8 @@ define([
533
533
* Init header elements
534
534
*/
535
535
initHeader : function ( ) {
536
- var data ;
536
+ var labels = [ ] ,
537
+ data ;
537
538
538
539
if ( ! this . labels ( ) . length ) {
539
540
_ . each ( this . childTemplate . children , function ( cell ) {
@@ -547,8 +548,9 @@ define([
547
548
sortOrder : cell . config . sortOrder
548
549
} ) ;
549
550
550
- this . labels . push ( data ) ;
551
+ labels . push ( data ) ;
551
552
} , this ) ;
553
+ this . labels ( _ . sortBy ( labels , 'sortOrder' ) ) ;
552
554
}
553
555
} ,
554
556
Original file line number Diff line number Diff line change @@ -131,5 +131,43 @@ define([
131
131
model . deleteRecord ( 1 , 1 ) ;
132
132
expect ( model . recordData ( ) ) . toEqual ( [ ] ) ;
133
133
} ) ;
134
+
135
+ it ( '"initHeader" sortOrder' , function ( ) {
136
+ var labels = [ {
137
+ name : 'Name 1' ,
138
+ config : {
139
+ label : 'Label 1' ,
140
+ validation : false ,
141
+ columnsHeaderClasses : '' ,
142
+ sortOrder : 10
143
+ }
144
+ } , {
145
+ name : 'Name 2' ,
146
+ config : {
147
+ label : 'Label 2' ,
148
+ validation : false ,
149
+ columnsHeaderClasses : '' ,
150
+ sortOrder : 5
151
+ }
152
+ } ] ,
153
+ result = [ {
154
+ label : 'Label 2' ,
155
+ name : 'Name 2' ,
156
+ required : false ,
157
+ columnsHeaderClasses : '' ,
158
+ sortOrder : 5
159
+ } , {
160
+ label : 'Label 1' ,
161
+ name : 'Name 1' ,
162
+ required : false ,
163
+ columnsHeaderClasses : '' ,
164
+ sortOrder : 10
165
+ } ] ;
166
+
167
+ model . childTemplate = {
168
+ children : labels
169
+ } ;
170
+ expect ( JSON . stringify ( model . labels ( ) ) ) . toEqual ( JSON . stringify ( result ) ) ;
171
+ } ) ;
134
172
} ) ;
135
173
} ) ;
You can’t perform that action at this time.
0 commit comments