ENGCOM-2176: Variable as a method parameter might be overridden by the loop #16143

Stanislav Idolov · web-flow · commit ee7e32f84e9d · 2018-07-08T15:27:07.000+03:00
diff --git a/app/code/Magento/Bundle/Model/Product/Type.php b/app/code/Magento/Bundle/Model/Product/Type.php
@@ -536,12 +536,12 @@ public function updateQtyOption($options, \Magento\Framework\DataObject $option,
 
         foreach ($selections as $selection) {
             if ($selection->getProductId() == $optionProduct->getId()) {
-                foreach ($options as &$option) {
-                    if ($option->getCode() == 'selection_qty_' . $selection->getSelectionId()) {
+                foreach ($options as $quoteItemOption) {
+                    if ($quoteItemOption->getCode() == 'selection_qty_' . $selection->getSelectionId()) {
                         if ($optionUpdateFlag) {
-                            $option->setValue(intval($option->getValue()));
+                            $quoteItemOption->setValue(intval($quoteItemOption->getValue()));
                         } else {
-                            $option->setValue($value);
+                            $quoteItemOption->setValue($value);
                         }
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -536,12 +536,12 @@ public function updateQtyOption($options, \Magento\Framework\DataObject $option,`
`536`	`536`
`537`	`537`	`foreach ($selections as $selection) {`
`538`	`538`	`if ($selection->getProductId() == $optionProduct->getId()) {`
`539`		`- foreach ($options as &$option) {`
`540`		`- if ($option->getCode() == 'selection_qty_' . $selection->getSelectionId()) {`
	`539`	`+ foreach ($options as $quoteItemOption) {`
	`540`	`+ if ($quoteItemOption->getCode() == 'selection_qty_' . $selection->getSelectionId()) {`
`541`	`541`	`if ($optionUpdateFlag) {`
`542`		`- $option->setValue(intval($option->getValue()));`
	`542`	`+ $quoteItemOption->setValue(intval($quoteItemOption->getValue()));`
`543`	`543`	`} else {`
`544`		`- $option->setValue($value);`
	`544`	`+ $quoteItemOption->setValue($value);`
`545`	`545`	`}`
`546`	`546`	`}`
`547`	`547`	`}`