GraphQL-375: Customer can get shipping/billing address data of any other customer

Author: naydav

app/code/Magento/QuoteGraphQl/Model/Cart/SetBillingAddressOnCart.php

@@ -7,9 +7,7 @@
 
 namespace Magento\QuoteGraphQl\Model\Cart;
 
-use Magento\Customer\Api\Data\AddressInterface;
 use Magento\CustomerGraphQl\Model\Customer\CheckCustomerAccount;
-use Magento\Framework\GraphQl\Exception\GraphQlAuthorizationException;
 use Magento\Framework\GraphQl\Exception\GraphQlInputException;
 use Magento\Framework\GraphQl\Query\Resolver\ContextInterface;
 use Magento\Quote\Api\Data\CartInterface;
@@ -64,18 +62,13 @@ public function __construct(
     }
 
     /**
-     * @inheritdoc
+     * Set billing address for a specified shopping cart
      *
      * @param ContextInterface $context
      * @param CartInterface $cart
      * @param array $billingAddress
-     * @throws GraphQlAuthorizationException
+     * @return void
      * @throws GraphQlInputException
-     * @throws \Magento\Framework\Exception\InputException
-     * @throws \Magento\Framework\Exception\LocalizedException
-     * @throws \Magento\Framework\Exception\NoSuchEntityException
-     * @throws \Magento\Framework\GraphQl\Exception\GraphQlAuthenticationException
-     * @throws \Magento\Framework\GraphQl\Exception\GraphQlNoSuchEntityException
      */
     public function execute(ContextInterface $context, CartInterface $cart, array $billingAddress): void
     {

app/code/Magento/QuoteGraphQl/Model/Cart/SetShippingAddressOnCart.php

@@ -8,7 +8,6 @@
 namespace Magento\QuoteGraphQl\Model\Cart;
 
 use Magento\CustomerGraphQl\Model\Customer\CheckCustomerAccount;
-use Magento\Framework\GraphQl\Exception\GraphQlAuthorizationException;
 use Magento\Framework\GraphQl\Exception\GraphQlInputException;
 use Magento\Framework\GraphQl\Query\Resolver\ContextInterface;
 use Magento\Quote\Api\Data\CartInterface;
@@ -64,13 +63,7 @@ public function __construct(
      * @param ContextInterface $context
      * @param CartInterface $cart
      * @param array $shippingAddresses
-     * @throws GraphQlAuthorizationException
      * @throws GraphQlInputException
-     * @throws \Magento\Framework\Exception\InputException
-     * @throws \Magento\Framework\Exception\LocalizedException
-     * @throws \Magento\Framework\Exception\NoSuchEntityException
-     * @throws \Magento\Framework\GraphQl\Exception\GraphQlAuthenticationException
-     * @throws \Magento\Framework\GraphQl\Exception\GraphQlNoSuchEntityException
      */
     public function execute(ContextInterface $context, CartInterface $cart, array $shippingAddresses): void
     {

app/code/Magento/QuoteGraphQl/etc/schema.graphqls

@@ -65,8 +65,8 @@ input SetShippingMethodsOnCartInput {
 
 input ShippingMethodForAddressInput {
     cart_address_id: Int!
-    shipping_carrier_code: String!
-    shipping_method_code: String!
+    carrier_code: String!
+    method_code: String!
 }
 
 type SetBillingAddressOnCartOutput {
@@ -117,7 +117,7 @@ type CartAddress {
     country: CartAddressCountry
     telephone: String
     address_type: AdressTypeEnum
-    selected_shipping_method: ShippingMethod
+    selected_shipping_method: SelectedShippingMethod
     available_shipping_methods: [AvailableShippingMethod] @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\ShippingAdress\\AvailableShippingMethods")
     items_weight: Float
     customer_notes: String
@@ -139,15 +139,8 @@ type CartAddressCountry {
     label: String
 }
 
-type ShippingMethod {
-    code: String
-    label: String
-    free_shipping: Boolean!
-    error_message: String
+type SelectedShippingMethod {
     amount: Float!
-    base_amount: Float!
-    amount_incl_tax: Float!
-    base_amount_incl_tax: Float!
 }
 
 type AvailableShippingMethod {