Merge pull request #403 from magento-jackalopes/MAGETWO-52837-command-return-nonzero-on-failure

[Jackalopes] Magetwo 52837 command return nonzero on failure (2.2 release)

Author: heyitsroberthe

app/code/Magento/Catalog/Console/Command/ProductAttributesCleanUp.php

@@ -101,11 +101,14 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $output->writeln("");
             $output->writeln("<info>Unused product attributes successfully cleaned up:</info>");
             $output->writeln("<comment>  " . implode("\n  ", $attributeTables) . "</comment>");
+            return \Magento\Framework\Console\Cli::RETURN_SUCCESS;
         } catch (\Exception $exception) {
             $this->attributeResource->rollBack();
 
             $output->writeln("");
             $output->writeln("<error>{$exception->getMessage()}</error>");
+            // we must have an exit code higher than zero to indicate something was wrong
+            return \Magento\Framework\Console\Cli::RETURN_FAILURE;
         }
     }