Skip to content

Commit fecf38c

Browse files
author
Oleksii Korshenko
authored
Merge pull request #359 from magento-falcons/MAGETWO-57569
Fixed issue: - MAGETWO-57569: [Backport] Functional upgrade test fail 2.1.x --> 2.2.x - 2.2
2 parents 9d0c8f9 + 9478003 commit fecf38c

File tree

5 files changed

+51
-3
lines changed

5 files changed

+51
-3
lines changed

dev/tests/functional/tests/app/Magento/Setup/Test/Block/SelectVersion.php

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,13 @@ class SelectVersion extends Form
3030
*/
3131
protected $firstField = '#selectVersion';
3232

33+
/**
34+
* Show all versions checkbox
35+
*
36+
* @var string
37+
*/
38+
private $showAllVersions = '#showUnstable';
39+
3340
/**
3441
* Click on 'Next' button.
3542
*
@@ -50,9 +57,24 @@ public function clickNext()
5057
public function fill(FixtureInterface $fixture, SimpleElement $element = null)
5158
{
5259
$this->waitForElementVisible($this->firstField);
60+
$this->chooseShowAllVersions();
61+
5362
return parent::fill($fixture, $element);
5463
}
5564

65+
/**
66+
* Show all versions include unstable
67+
*
68+
* @return void
69+
*/
70+
private function chooseShowAllVersions()
71+
{
72+
$element = $this->_rootElement->find($this->showAllVersions, Locator::SELECTOR_CSS);
73+
if ($element->isVisible()) {
74+
$element->click();
75+
}
76+
}
77+
5678
/**
5779
* Choose 'yes' for upgrade option called 'Other components'
5880
*

dev/tests/functional/tests/app/Magento/Setup/Test/Constraint/AssertSuccessMessage.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class AssertSuccessMessage extends AbstractConstraint
2323
*/
2424
public function processAssert(SetupWizard $setupWizard, $package)
2525
{
26-
$message = "You upgraded:";
26+
$message = "You upgraded";
2727
\PHPUnit_Framework_Assert::assertContains(
2828
$message,
2929
$setupWizard->getSuccessMessage()->getUpdaterStatus(),

dev/tests/functional/testsuites/Magento/Mtf/TestSuite/InjectableTests/setup.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,8 @@
1111
<allow>
1212
<module value="Magento_Setup"/>
1313
</allow>
14+
<deny>
15+
<class value="Magento\Setup\Test\TestCase\UpgradeSystemTest"/>
16+
</deny>
1417
</rule>
1518
</config>
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<?xml version="1.0"?>
2+
<!--
3+
/**
4+
* Copyright © 2016 Magento. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9+
xsi:noNamespaceSchemaLocation="../../../../../vendor/magento/mtf/Magento/Mtf/TestRunner/etc/testRunner.xsd">
10+
<rule scope="testsuite">
11+
<allow>
12+
<class value="Magento\Setup\Test\TestCase\UpgradeSystemTest"/>
13+
</allow>
14+
</rule>
15+
</config>

setup/pub/magento/setup/updater-success.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,16 @@ angular.module('updater-success', ['ngStorage'])
88
.controller('updaterSuccessController', ['$scope', '$state', '$localStorage', '$window', 'navigationService', function ($scope, $state, $localStorage, $window, navigationService) {
99
if ($localStorage.successPageAction) {
1010
$scope.successPageAction = $localStorage.successPageAction;
11-
$scope.successPageActionMessage = $scope.successPageAction +
12-
($scope.endsWith($scope.successPageAction, 'e') ? 'd' : 'ed');
11+
switch (true) {
12+
case $scope.endsWith($scope.successPageAction, 'd'):
13+
$scope.successPageActionMessage = $scope.successPageAction;
14+
break;
15+
case $scope.endsWith($scope.successPageAction, 'e'):
16+
$scope.successPageActionMessage = $scope.successPageAction + 'd';
17+
break;
18+
default:
19+
$scope.successPageActionMessage = $scope.successPageAction + 'ed';
20+
}
1321
}
1422
if ($localStorage.packages) {
1523
$scope.packages = $localStorage.packages;

0 commit comments

Comments
 (0)