Please add your expectations for @deprecated annotations

[flancer64]

Hello,

I try to create own code based on the \Magento\Checkout\Controller\Cart\Add class. I see that this class uses \Magento\Checkout\Model\Cart class that has @deprecated annotation. I could use other class in my code but I don't know your expectations - which other class does Magento team use instead of deprecated \Magento\Checkout\Model\Cart?

It would be more pleasantly if @deprecated annotations will have comments that point to expected replacements. Something like:

/**
 * Shopping cart model
 * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
 * @deprecated use \Magento\Quote\Model\Quote
 */
class Cart extends DataObject implements CartInterface {...}

I know, there are a lot of deprecated classes/methods in the code (> 500) and Magento team cannot comment all of them at once. However, the source code is a primary documentation for developers and all developers read the sources. Your plans (expectations) will be more understandable for us if you will write it just a little wider in the sources.

Thanks.

[magento-engcom-team]

Hi @flancer64 thank you for pointing on this. We already have this as a part of our commitment in Backward compatible development We still have some tech debt, but we are working to minimize it.
Feel free to submit pull request to address the most painful issues for you. Thank you

[magento-engcom-team]

Hi @flancer64. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1359 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

• 1db3f8f
• 412d228
• 02620b0
• 57c5d8a
• 94a3f03
• 0d557dc
• 48baf59
• dc3bb78
• 0ab4533
• 00f64b0
• 440a1b5
• 4ed8f5b
• 656eeb5
• fd2f731
• 2c1a23f
• f7ff71a
• ac9bcfa
• 55debe0
• 3495086
• d678f15
• bf8ee30
• 335c91c
• c5a823f
• 696a5a5

The fix will be available with the upcoming 2.3.0 release.