2.2.6 "Special price date from" Failed to parse time string

[Cristiano81]

Preconditions

1. Magento 2.2.6
2. Account locale set to it_IT

Steps to reproduce

1. Magento 2.2.6 create a new product with a price
2. Edit the new product and add a special price

Expected result

1. The product has been saved

Actual result

1. DateTime::__construct(): Failed to parse time string (20/09/2018) at position 0 (2): Unexpected character

This worked on 2.2.5

[magento-engcom-team]

Hi @Cristiano81. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@Cristiano81 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[magento-engcom-team]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label G1 Passed will be added to the issue automatically. Please, edit issue description if needed, until label G1 Passed appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add G2 Passed label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label acknowledged once verification is complete.

• 7. Make sure that automatic system confirms that report is acknowledged.

[ghost]

Hi @Cristiano81 thank you for you report, i'm not able to reproduce following steps you described.
I'm have saved product.

[magento-engcom-team]

@engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-95124, MAGETWO-95125 were created

[Cristiano81]

yes i can reproduce on vanilla Magento https://i-18157-2-2-6.engcom.dev.magento.com
i have to add some precondition

1. Magento 2.2.6
2. Account locale set to it_IT
3. Locale options: locale italiano (italia)

to reproduce the issue after edit the product to insert the special price, save it again, elsewhere in first instance it works (when special price date from is empty)

[Cristiano81]

i think i have found the reason.
in /vendor/magento/module-catalog/Controller/Adminhtml/Product/Initialization/Helper.php
has been added a new function on line 463

private function convertSpecialFromDateStringToObject($productData)
    {
        if (isset($productData['special_from_date']) && $productData['special_from_date'] != '') {
            $productData['special_from_date'] = new \DateTime($productData['special_from_date']);
        }

        return $productData;
    }

comment the call to that function on line 162
//$productData = $this->convertSpecialFromDateStringToObject($productData);

the product has been saved successfully again

[magento-engcom-team]

Hi @hiren0241. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

[sidolov]

Hi @Cristiano81. Thank you for your report.
The issue has been fixed in #18578 by @hiren0241 in 2.3-develop branch
Related commit(s):

• 4e382cc735a883c9dcd8eaeeedc185d7faa06a7f
• fd8a5a90b32431fbdd275000624723b106c81841
• 88592facd5d34872ac2f2051dda246703091cacc

The fix will be available with the upcoming 2.3.1 release.

[paul-blundell]

This is a fairly major problem, why the decision to wait until 2.3.1 to rollout any fix?

[ghost]

@Cristiano81 this issue present in 2.3-develop instance with Account locale set to en_GB

[sidolov]

Hi @paul-blundell , we expecting 2.3 release very soon, but current fix will be available in 2.3.1 version according to the previous comment.

[paul-blundell]

@sidolov but that fix apparently hasn't resolved the issue anyway. Any idea when this will be resolved?

[alefemafra]

I created a fix to solve this problem, following the hint of @Cristiano81, follow the link of the repository, just download and put in app/code, and follow the installation standard of the module.

https://github.com/alefemafra/module-fix-date-product-error

[ghost]

Hi @Cristiano81 , thank you for you report, this issue has already fixed in 2.3-develop branch, and will be available on 2.3.1 release.

[magento-engcom-team]

Hi @Cristiano81. Thank you for your report.
The issue has been fixed in #21273 by @tufahu in 2.2-develop branch
Related commit(s):

• 4d9e6c8f946594af042c9d8eec8e82ecc63aa307
• 523567461e74dd4580fe8e4e59d71aeae8191042
• ad5bf08df72a5115b2777ebf55b2fc8530c88d3e

The fix will be available with the upcoming 2.2.9 release.