Checkout - Infinite loading indicator when server returned error

[ihor-sviziev]

Preconditions

1. Magento 2.2.6

Steps to reproduce

1. Create any simple product
2. Add to cart it on frontend and go to checkout
3. Open Chrome Dev Tools
4. Fill up shipping in US with any address
5. Find request to request like this: https://test-magento-instance.com/rest/default/V1/guest-carts/gFgmi7qopaxOgxlbXQ3hEo2Ny8gkNXXl/estimate-shipping-methods
6. Right click on this request on click "Block request URL" in order to emulate that we can't connect to server or server returned an error
   
7. Change zipcode in shipping address and see that estimate-shipping-methods request was blocked in Dev Tools:
   

Expected result

1. Loading indicator should be hidden
2. No shipping methods should be available

Actual result

1. Infinite scrolling in "Shipping methods" appeared

Additional info

Issue appearing here:
https://test-magento-instance.com/pub/static/version1538398224/frontend/Magento/luma/en_US/Magento_Checkout/js/model/shipping-rate-processor/new-address.js contains following line - errorProcessor tries to process response

but it can't process JSON.parse on empty string and throwing exception:

As result we "always" section in new-address.js file is not processed.

We have following JS error in console:

PS: I tested it on following test instance: https://i-18112-2-2-6.engcom.dev.magento.com/test.html

[magento-engcom-team]

Hi @ihor-sviziev. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@ihor-sviziev do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[magento-engcom-team]

Hi @ihor-sviziev. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

@ihor-sviziev Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-95448, MAGETWO-95449 were created

[slavvka]

Hi @ihor-sviziev. Thank you for your report.
The issue has been fixed in #18331 by @ihor-sviziev in 2.3-develop branch
Related commit(s):

• eea11c733b94d60639dabc4f83752c51ea1a70e5

The fix will be available with the upcoming 2.3.1 release.

[magento-engcom-team]

Hi @ihor-sviziev. Thank you for your report.
The issue has been fixed in #18369 by @ihor-sviziev in 2.2-develop branch
Related commit(s):

• 74bed695b4ac0f381b10368c7d8a780b52b5c9f9

The fix will be available with the upcoming 2.2.8 release.