Skip to content

[Configurable] JS error on product page #25601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ihor-sviziev opened this issue Nov 14, 2019 · 8 comments
Closed

[Configurable] JS error on product page #25601

ihor-sviziev opened this issue Nov 14, 2019 · 8 comments
Assignees
Labels
Area: Frontend Component: ConfigurableProduct Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Nov 14, 2019

Preconditions (*)

  1. Magento 2.3.3 or 2.3-develop

Steps to reproduce (*)

  1. Create Configurable product
  2. Go to this product on frontend
  3. Add this product to cart,
    image
  4. In the mini cart or on the cart page click on "Edit" (image) icon
  5. Open Google Chrome Developer tools

Expected result (*)

  1. You should not see any JS errors
  2. Already selected configurable option should be selected

Actual result (*)

  1. We have JS error
Uncaught TypeError: Cannot read property 'find' of undefined
    at $.<computed>.<computed>.updateMsrpPrice (msrp.js:355)
    at $.<computed>.<computed>.updateMsrpPrice (widget.js:100)
    at $.<computed>.<computed>.onUpdateMsrpPrice (msrp.js:333)
    at $.<computed>.<computed>.onUpdateMsrpPrice (widget.js:100)
    at HTMLDocument.dispatch (jquery.js:5232)
    at HTMLDocument.elemData.handle (jquery.js:4884)
    at Object.trigger (jquery.js:5136)
    at Object.jQuery.event.trigger (jquery-migrate.js:633)
    at HTMLDocument.<anonymous> (jquery.js:5866)
    at Function.each (jquery.js:376)

image
2. Already selected configurable option is not selected

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 14, 2019

Hi @ihor-sviziev. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@ihor-sviziev do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@ihor-sviziev
Copy link
Contributor Author

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, here is your Magento instance.
Admin access: https://i-25601-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@m2-assistant
Copy link

m2-assistant bot commented Nov 14, 2019

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash krishprakash added Area: Frontend Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release ShoppingCart and removed Component: ConfigurableProduct labels Nov 14, 2019
@ghost ghost unassigned krishprakash Nov 14, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Nov 14, 2019
@magento-engcom-team
Copy link
Contributor

@krishprakash Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@krishprakash krishprakash added Component: Checkout Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 14, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-23138 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 14, 2019
@krishprakash krishprakash added Component: ConfigurableProduct and removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Component: Checkout labels Nov 14, 2019
@ghost ghost assigned ihor-sviziev Nov 14, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your report.
The issue has been fixed in #25606 by @ihor-sviziev in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: ConfigurableProduct Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants