Skip to content

Support for PHP 7.4 #27227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rvitaliy opened this issue Mar 10, 2020 · 9 comments
Closed

Support for PHP 7.4 #27227

rvitaliy opened this issue Mar 10, 2020 · 9 comments
Labels
feature request Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed

Comments

@rvitaliy
Copy link
Member

PHP 7.4 has been released in november 2019. It would be nice to see Magento 2 supported it.

@m2-assistant
Copy link

m2-assistant bot commented Mar 10, 2020

Hi @rvitaliy. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@rvitaliy do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Mar 10, 2020
@sdzhepa
Copy link
Contributor

sdzhepa commented Mar 17, 2020

Hello @rvitaliy

Sorry but I am closing this issue due to

Before creating an issue, please do the following:
...

  • Make sure, that information you are about to report is a technical issue, please refer to the Community Forums or Magento Stack Exchange for technical questions, feature requests, etc. These reports are not guaranteed to be processed within GitHub issue tracker.
    ...

@rvitaliy
Copy link
Member Author

rvitaliy commented Apr 7, 2020

Hello @sdzhepa

I apologize for the inconvenience, I believe there is nothing to add as technical information for this issue.
I would ask you to reopen it and remove the done tag as this feature has not yet been implemented.

@hostep
Copy link
Contributor

hostep commented Apr 14, 2020

I'm re-opening, because I agree that we need some sort of ticket to keep track of support for upcoming PHP versions. It's interesting to follow this, and that Magento developers can post updates in here to announce progress and when we can expect a Magento release compatible with PHP 7.4
In the thread for PHP 7.3, the same thing happened.

@sdzhepa, if you don't agree, then at least keep it open and move it to https://github.com/magento/community-features/ repository.

@hostep hostep reopened this Apr 14, 2020
@sdzhepa
Copy link
Contributor

sdzhepa commented Apr 15, 2020

Hello @rvitaliy @hostep

Wow, it seems I become dislike champion in this thread...
Sorry for my strict answer and manners and let me explain the decision to close the issue

  • reported issue it's not kine of bug or task that can be fixed and delivered here with community PR
  • it's very complex task that required changes(and full testing) not only in Magento code itself but for all staff around. Not all of them are public available

So, for my point of view, such task should be done by Magento internally.

But despite all my excuses, let me share an additional update about it. Not sure that I can share it publicly, it is not any kind of official announcement but just only my personal thoughts.
At this moment in the internal backlog, there are a lot of tasks/stories/epics to upgrade the PHP version to 7.4. These tasks in progress now and internal teams are working hard to make it reals as soon as possible. I hope it will be done with one of the next 2.4.x releases.
Due to the huge amount of internal tasks/tickets related to this, I am not able to provide a regular status update as a comment for this issue(manually or automatically)
The final update for this issue will be in the release notes.

I still think that we can close this issue but if you want we can keep it open and close only based on release notes related to php7.4

Sorry again for any inconveniences

UPDATE:

@hostep
Copy link
Contributor

hostep commented Apr 15, 2020

@sdzhepa: thanks for the update! You can close the issue from my part, but it's just nice to keep the community updated around what happens and once most work is done and there is a known date for when a version can be expected that is compatible with PHP 7.4, it would be nice that this can get announced somehow.

A lot of work Magento is doing internally is interesting to know but some stuff remains hidden, which is a bit unfortunate for an open source project. I'm just asking for a little bit of transparency. Opening up that branch to the public is a nice gesture!

If magento/magento2 is not the correct repo for keeping track of PHP 7.4 progress, then maybe magento/community-features or magento/backlog or the devblog is?

@rvitaliy
Copy link
Member Author

Hi @sdzhepa!
Thanks for update and sorry for this dislikes, is not my scope.

I think that this kind of work must be open and related to a card like this to keep community updated.

My suggestion is that Mangento must keep in mind that they have many external libs that must be updated for properly work with new release, if community doesn't know whats happen in next release it's hard to be ready for update...
So, please, take care about update of our comunity.

I think that this issue can't be closed before upgdare to php 7.4 is not completed. It's usefull for other people to see that Magento is working on this issue.

@hostep
Copy link
Contributor

hostep commented May 12, 2020

Yay, it looks like PHP 7.4 support got recently merged in the 2.4-develop branch: 40a7876

So that will probably be included in Magento 2.4.0 or 2.4.1?

Not sure if there are plans for backporting it to 2.3.x ?

@rvitaliy
Copy link
Member Author

rvitaliy commented Aug 3, 2020

latest magento version support php 7.4 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed
Projects
None yet
Development

No branches or pull requests

4 participants