Skip to content

The constructor of the class \Magento\Framework\View\TemplateEngine\Xhtml\ResultFactory can be shortened by using PHP 5.5 class name resolution via ::class #2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitrii-fediuk opened this issue Dec 23, 2015 · 2 comments
Closed

The constructor of the class \Magento\Framework\View\TemplateEngine\Xhtml\ResultFactory can be shortened by using PHP 5.5 class name resolution via ::class #2794

dmitrii-fediuk opened this issue Dec 23, 2015 · 2 comments
Labels
improvement

Comments

@dmitrii-fediuk
Copy link

https://mage2.pro/t/310
@shiftedreality
Copy link
Member

Hi, @dfediuk

We have many places with possible use of ::class notations. This is not issue and will be improved in future.

@piotrekkaminski
Copy link
Contributor

Closing in favor of more generic #4068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dmitrii-fediuk @victorgugo @piotrekkaminski @shiftedreality @MomotenkoNatalia