Skip to content

[Issue] Newsletter subscription emails should also use paragraph tags #28166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue May 8, 2020 · 2 comments · Fixed by #27357
Closed

[Issue] Newsletter subscription emails should also use paragraph tags #28166

ghost opened this issue May 8, 2020 · 2 comments · Fixed by #27357
Assignees
@ptylek
Labels
Component: Newsletter Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@ghost
Copy link

ghost commented May 8, 2020 •
edited by VladimirZaets
Loading

Preconditions

Description (*)

Other emails (also subscription confirmation email in the same module) are using proper html tags for their content.

<p>{{trans "To begin receiving the newsletter, you must first confirm your subscription by clicking on the following link:"}}</p>

The same should apply for newsletter subscription and unsubscription emails.

This will help in keeping same email styling.

Steps to reproduce

  1. As a logged in user go to User Area - Newsletter section and subscribe / unsubscribe to the newsletter.
  2. Go to your email box and check those emails

Expected result (*)

Actual result (*)
@ghost ghost added the Component: Newsletter label May 8, 2020
@ptylek ptylek mentioned this issue May 8, 2020
Merged
5 tasks
@ghost ghost assigned ptylek May 8, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label May 8, 2020
@ghost ghost added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. labels May 8, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels May 27, 2020
@VladimirZaets VladimirZaets added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels May 27, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 27, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @VladimirZaets
Thank you for verifying the issue. Based on the provided information internal tickets MC-34700 were created

Issue Available: @VladimirZaets, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@slavvka
Copy link
Member

slavvka commented Jun 5, 2020

Hi @m2-backlog[bot]. Thank you for your report.
The issue has been fixed in #27357 by @ptylek in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jun 5, 2020
@slavvka slavvka closed this as completed Jun 5, 2020
@ghost ghost added the Progress: done label Jun 5, 2020
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptylek ptylek

Labels
Component: Newsletter Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Newsletter subscription emails should also use paragraph tags ptylek/magento2
4 participants
@VladimirZaets @slavvka @magento-engcom-team @ptylek