Skip to content

Issue in Dob field. #28482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ankush-Webkul opened this issue Jun 3, 2020 · 23 comments
Closed

Issue in Dob field. #28482

Ankush-Webkul opened this issue Jun 3, 2020 · 23 comments
Assignees
Labels
Component: Customer Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reported on 2.3.5 Indicates original Magento version for the Issue report.

Comments

@Ankush-Webkul
Copy link

Getting an issue on the Registration page if the Dob field is enabled from admin.
https://prnt.sc/ssty7t

Preconditions (*)
Use Magento 2.3.5 instance

Steps to reproduce (*)

  1. Enable the Dob field from admin.
  2. create New customer account with Dob.

Expected result (*)
The Account is created with customer Dob.

Actual result (*)
The account is not created and shows and error in the Dob field that "Please Enter the correct Dob".

@m2-assistant
Copy link

m2-assistant bot commented Jun 3, 2020

Hi @Ankush-Webkul. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jun 3, 2020
@swathishs swathishs self-assigned this Jun 3, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 3, 2020

Hi @swathishs. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@swathishs
Copy link

@magento give me 2.3.5-p1 instance

@magento-engcom-team
Copy link
Contributor

Hi @swathishs. Thank you for your request. I'm working on Magento 2.3.5-p1 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @swathishs, here is your Magento instance.
Admin access: https://i-28482-2-3-5-p1.instances.magento-community.engineering/admin_c67a
Login: 8a07645c Password: 0b23c0fb743f
Instance will be terminated in up to 3 hours.

@swathishs
Copy link

The issue is reproducible on Magento 2.3.5pl develop instance

Please find the attachment below:
image

Note: I can able to create account if I try to keep the current month first day(06/1/2020) as a dob in this instance

@swathishs
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @swathishs. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @swathishs, here is your Magento instance.
Admin access: https://i-28482-2-4-develop.instances.magento-community.engineering/admin_f61b
Login: a501ebf0 Password: a10a40d13625
Instance will be terminated in up to 3 hours.

@swathishs
Copy link

The issue is not reproducible on Magento 2.4 develop instance

Please find the attachment below:
BEmcugVErt

@swathishs
Copy link

Can be reproduced only on 2.3.5p1 but not on 2.4 develop instance

@swathishs swathishs added Component: Customer Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Reproduced on 2.3.5p1 Only if reproduced on 2.3.5p1 but not on 2.4-develop Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jun 3, 2020
@ghost ghost unassigned swathishs Jun 3, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @swathishs
Thank you for verifying the issue. Based on the provided information internal tickets MC-34824 were created

Issue Available: @swathishs, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@pmgephart
Copy link

Hi @swathishs and @magento-engcom-team,

I was able to reproduce this issue on our instance of Magento 2.3.5-p1. The error given was:

"Please enter a valid date."

In /vendor/magento/module-customer/Block/Widget/Dob.php I changed the line:

$escapedDateFormat = preg_replace('/[^MmDdYy\/\.\-]/', '', $dateFormat);

to:

$escapedDateFormat = 'M/dd/Y';

It seems the frontend validation wants this date format instead of 'M/d/Y'. Please let me know if this fixes your issue.

@chandu-pinpoint
Copy link

@magento I am working on this

@chandu-pinpoint
Copy link

chandu-pinpoint commented Jun 11, 2020

@magento and @Ankush-Webkul
I have created a patch for 2.3.5-p1 here: chandu-pinpoint@d3f8e54
I hope this helps.

@zaietsv
Copy link

zaietsv commented Jun 23, 2020

@magento and @Ankush-Webkul
I have created a patch for 2.3.5-p1 here: chandu-pinpoint@d3f8e54
I hope this helps.

Thank you! It really works!
PS: Magento team BOOO...

@magento-engcom-team magento-engcom-team removed the Reproduced on 2.3.5p1 Only if reproduced on 2.3.5p1 but not on 2.4-develop label Jun 25, 2020
@magento-engcom-team magento-engcom-team added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Progress: dev in progress Progress: done and removed Progress: ready for dev Progress: dev in progress Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jun 25, 2020
@magento-engcom-team
Copy link
Contributor

Hi @Ankush-Webkul, @chandu-pinpoint.

Thank you for your report and collaboration!

The related internal Jira ticket MC-34824 was closed as non-reproducible in 2.3-develop.
It means that Magento team either unable to reproduce this issue using provided Steps to Reproduce from the Description section on clean Magento instance or the issue has been already fixed in the scope of other tasks.

But if you still run into this problem please update or provide additional information/steps/preconditions in the Description section and reopen this issue.

@magento-engcom-team magento-engcom-team added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Jun 26, 2020
@magento-engcom-team
Copy link
Contributor

Hi @Ankush-Webkul, @chandu-pinpoint.

Thank you for your report and collaboration!

The related internal Jira ticket MC-34824 was closed as non-reproducible in 2.3-develop.
It means that Magento team either unable to reproduce this issue using provided Steps to Reproduce from the Description section on clean Magento instance or the issue has been already fixed in the scope of other tasks.

But if you still run into this problem please update or provide additional information/steps/preconditions in the Description section and reopen this issue.

@hostep
Copy link
Contributor

hostep commented Jul 2, 2020

I think this got fixed in 2.4-develop with MC-31117 in scope of #26700, but might be wrong about this.

@verdde
Copy link

verdde commented Jul 7, 2020

Was not fixed. 2.3.5-p1 The patch made by chandu-pinpoint is temporary fixing the issue.
For 2.4 there is an opened issue #26443
@magento-engcom-team

@sdzhepa
Copy link
Contributor

sdzhepa commented Aug 17, 2020

Hello @Ankush-Webkul

Update based on internal Jira.
The issue has been fixed by internal team in the scope of MC-32364 internal ticket. Fix was delivered into 2.3.x branch
Target fix version is next 2.3.6 release

@sdzhepa sdzhepa closed this as completed Aug 17, 2020
@VincentMarmiesse
Copy link
Contributor

This issue still exists in 2.3.6.
It's OK in front but is not in Admin when the locale is not en_US.

@dssjignesh
Copy link

dssjignesh commented Nov 3, 2020

In admin locale except for en_US , there is still issue

@magento-engcom-team magento-engcom-team added the Reported on 2.3.5 Indicates original Magento version for the Issue report. label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customer Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reported on 2.3.5 Indicates original Magento version for the Issue report.
Projects
None yet
Development

No branches or pull requests