Custom update layout XML not applied to product page in 2.3.5-p1 #28750

kardi31 · 2020-06-17T07:13:08Z

Preconditions (*)

2.3.5-p1

Steps to reproduce (*)

Create product view layout file app/code/{Namespace}/{Module}/view/frontend/layout/catalog_product_view_selectable_{productIdentifier}_removebreadcrumbs.xml with content <referenceBlock name="breadcrumbs" remove="true" />
Go to product page in admin panel, in design section apply removebreadcrumbs custom layout update.
Go to product page on frontend

Expected result (*)

Breadcrumbs from product page should be removed

Actual result (*)

Breadcrumbs are still visible on product page.

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

Severity: S0 - Affects critical data or functionality and leaves users without workaround.
Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

The text was updated successfully, but these errors were encountered:

m2-assistant · 2020-06-17T07:13:10Z

Hi @kardi31. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

Blatant · 2020-08-06T19:31:14Z

Same for me .

I'm trying to update alyout of the home CMS Page, I created file :
\[VENDOR]\[THEME]\Magento_Cms\layout\cms_page_view_selectable_home_NewTest.xml
Flushed the Cache
Edited the "Homepage" home CMS Page, I can see "NewTest" in the selector and when I select it and Save it does save (revisiting CMS page editor later shows the value as saved) however no layout update is being performed, cleared and flushed cache.
Pretty Straight forward proof of concept :

<?xml version="1.0"?>
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
    <body>
        <referenceContainer name="main.content">
            <block name="mytest"
                   template="Magento_Theme::test.phtml"
                   before="-" />
        </referenceContainer>
    </body>
</page>

Blatant · 2020-08-07T13:02:51Z

I actually solved my issue, posting here in case it helps....
For me I had missed the <update handle="" /> declaration in my XML file....
This example works 100% for me :

\Vendor\Theme\Magento_Cms\layout\cms_page_view_selectable_home_NewTest.xml :

<?xml version="1.0"?>
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
    <update handle="cms_page_view_selectable_home_NewTest"/>
    <referenceContainer name="main.content">
            <block name="mytest"
                   template="Magento_Theme::test.phtml"
                   before="-" />
    </referenceContainer>
</page>

FYI the handle name is the full name of your file!

Blatant · 2020-08-12T10:14:36Z

I wanted to add a little update to the above for CMS pages.

Firstly, you can use any update handle that's available, it doesn't have to be the file name. This mightbe obvious but I wanted to explicitly declare it. For example default or cms_page_view work just as well.

Second, turns out the homepage ignores Layout Updates, because it generates from a different controller (cms_index_index not cms_page_view"), while Layout is aware of this (and adds extra update handles) the file loader for the layout files is not!

To fix it, copy your layout file and rename from cms_page_view to cms_index_index. You will have to update layout in 2 places, and do not change the page ID or the Layout name on the file!. Make sure you use a handle that is present on both homepage and CMS page view (like default or cms_page_view).

Example :
Vendor\Theme\Magento_CMS\layout\cms_page_view_selectable_home_MyHomeLayout.xml

<?xml version="1.0"?>
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
    <update handle="cms_page_view"/>
    <referenceContainer name="main">
        <!-- Home - Store Locator -->
        <block name="block.test" before="-" template="testblock.phtml"/>
    </referenceContainer>
</page>

Copy to : Vendor\Theme\Magento_CMS\layout\cms_index_index_selectable_home_MyHomeLayout.xml
(Same file as above)

m2-assistant · 2021-01-14T13:27:14Z

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
5. Add label Issue: Confirmed once verification is complete.
6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Alfa · 2021-01-14T13:47:30Z

Hi @kardi31. Thank you for your report!

Unfortunately, we are not able to reproduce the issue on fresh 2.4-develop. Looks like the problem has already been fixed.

Manual testing scenario:

Create simple product ("test" for ex.);
Create product view layout file app/code/{Namespace}/{Module}/view/frontend/layout/catalog_product_view_selectable_{productIdentifier "test" in our case}_removebreadcrumbs.xml with content :

<?xml version="1.0"?>
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
    <body>
        <referenceBlock name="breadcrumbs" remove="true"/>
    </body>
</page>

Go to the product page in the admin panel, in the design section, apply removebreadcrumbs custom layout update.
Go to the product page on frontend;

Actual Result: ✔️ Breadcrumbs from the product page are removed

So, we have to close it.
Please feel free to comment, reopen or create new ticket according to the Issue reporting guidelines
if you are still facing this issue on the latest 2.4-develop branch. Thank you for collaboration.

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jun 17, 2020

ghost added the Progress: ready for QA label Jun 17, 2020

Blatant mentioned this issue Aug 7, 2020

2.3.4: Update "Custom Layout Update" doesn't work #27942

Closed

m2-community-project bot removed the Progress: ready for QA label Sep 24, 2020

ghost added Issue: ready for confirmation and removed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Oct 21, 2020

magento-engcom-team added the Reported on 2.3.5-p1 Indicates original Magento version for the Issue report. label Nov 13, 2020

engcom-Alfa self-assigned this Jan 14, 2021

engcom-Alfa closed this as completed Jan 14, 2021

engcom-Alfa added the not-confirmed Use for Issue that was closed during confirmation label Jan 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom update layout XML not applied to product page in 2.3.5-p1 #28750

Custom update layout XML not applied to product page in 2.3.5-p1 #28750

kardi31 commented Jun 17, 2020

m2-assistant bot commented Jun 17, 2020

Blatant commented Aug 6, 2020

Blatant commented Aug 7, 2020

Blatant commented Aug 12, 2020

m2-assistant bot commented Jan 14, 2021

engcom-Alfa commented Jan 14, 2021

Custom update layout XML not applied to product page in 2.3.5-p1 #28750

Custom update layout XML not applied to product page in 2.3.5-p1 #28750

Comments

kardi31 commented Jun 17, 2020

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

m2-assistant bot commented Jun 17, 2020

Blatant commented Aug 6, 2020

Blatant commented Aug 7, 2020

Blatant commented Aug 12, 2020

m2-assistant bot commented Jan 14, 2021

engcom-Alfa commented Jan 14, 2021