Skip to content

Naviagtion delay in _startOpening not working in magento 2.3.5-p1 #28754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
stkrelax opened this issue Jun 17, 2020 · 4 comments
Closed
1 task

Naviagtion delay in _startOpening not working in magento 2.3.5-p1 #28754

stkrelax opened this issue Jun 17, 2020 · 4 comments
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.5-p1 Indicates original Magento version for the Issue report. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. stale issue Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@stkrelax
Copy link

Preconditions (*)

  1. magento 2.3.5-p1
  2. changed topmenu.phtml --> "delay":300 added
<nav class="navigation bla" data-action="navigation">
    <ul data-mage-init='{"menu":{"responsive":true, "delay":300, "expanded":true, "position":{"my":"left top","at":"left bottom"}}}'>
        <?= /* @noEscape */ $_menuHtml?>
        <?= $block->getChildHtml() ?>
    </ul>
</nav>

Steps to reproduce (*)

  1. open menu via mouse over
  2. close menu via mouse leave

Expected result (*)

  1. _startOpening method uses delay
  2. _close uses delay

Actual result (*)

  1. _startOpening does not use delay anymore
  2. _close uses delay as provided

Reason

this commit
747846e

from this "fixed" issue
#25589


  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Jun 17, 2020

Hi @stkrelax. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jun 17, 2020
@engcom-Lima engcom-Lima added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Jul 3, 2020
@VladimirZaets VladimirZaets added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 17, 2020
@nkajic
Copy link
Member

nkajic commented Nov 9, 2020

Hi @stkrelax thank you so much for reporting this reference - it saved me additional time debugging root cause to this problem.

We also had same problem and it was making menu user un-friendly since since it was missing this delay.

Here is reference how pure jquery menu should act with delay on showing submenu. https://jqueryui.com/menu/ Two different worlds.

Removing delay entirely was definitely not the right solution to fix it #25589

Reproduced on 2.4-develop

@magento-engcom-team magento-engcom-team added the Reported on 2.3.5-p1 Indicates original Magento version for the Issue report. label Nov 13, 2020
@stkrelax
Copy link
Author

@nkajic you're welcome ;)

@stale
Copy link

stale bot commented Feb 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.5-p1 Indicates original Magento version for the Issue report. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. stale issue Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Development

No branches or pull requests

5 participants