-
Notifications
You must be signed in to change notification settings - Fork 9.4k
merge js files has no effect #2925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Here's full run-down of core-config if needed for diagnosis:
MAGE_MODE is set to production and all static assets were compiled. |
Please try changing "dev/js/enable_js_bundling" to 1. I think the merging just merges files not using require.js. For all other files, this it still makes the require.js to inject them via script tags in the head tag. This causes the browser to download the remaining files separately and asynchronously. |
Yes, merge_files doesn't do much as it just merges js in the layout head section. The bundling in theory supposed to merge and optimize other js that loads through requireJs but I believe there are still issues with it. |
Not a bug. |
See this page for webpagetest results:
http://www.webpagetest.org/result/160108_GR_A6S/
It doesn't appear the
dev/js/merge_files
has any effect. I expect that this toggled on would only show a few js files at most (if not one file).The text was updated successfully, but these errors were encountered: