Skip to content

[Issue] Add an option for setup:config:set to define the document root #29523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
m2-assistant bot opened this issue Aug 13, 2020 · 3 comments
Closed
4 tasks done

[Issue] Add an option for setup:config:set to define the document root #29523

m2-assistant bot opened this issue Aug 13, 2020 · 3 comments
Labels
Component: Config Component: Developer Component: Filesystem Component: MessageQueue Component: Setup Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.x Indicates original Magento version for the Issue report. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. stale issue

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 13, 2020

This issue is automatically created based on existing pull request: #29176: Add an option for setup:config:set to define the document root


Preconditions: (*)

Add bin/magento setup:config:set --document-root-is-pub
I think this is needed in order to raise awareness for https://devdocs.magento.com/guides/v2.3/install-gde/tutorials/change-docroot-to-pub.html section 3, and to simplify automating this setting in deployment scripts.

Related Pull Requests

Fixed Issues (if relevant)

Steps to reproduce: (*)

Run in console: bin/magento setup:config:set --document-root-is-pub 1 or true or yes

Expected Result: ✔️ the values ​​should be in the correct format (boolean)

Screenshot from 2020-09-10 16-22-30

Run in console: bin/magento setup:config:set --allow-parallel-generation 1 or true or yes

Expected Result: ✔️ the values ​​should be in the correct format (boolean)

Screenshot from 2020-09-10 16-26-13

Run in console: `in/magento setup:config:set --consumers-wait-for-messages 0 or false or no

Expected Result: ✔️ the values should be in the correct format (1/0)

Screenshot from 2020-09-10 16-27-43

Actual Result:

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Config Component: Developer Component: Filesystem Component: MessageQueue Component: Setup Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 13, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 13, 2020
@sidolov sidolov added the Priority: P3 May be fixed according to the position in the backlog. label Aug 13, 2020
@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. and removed Priority: P3 May be fixed according to the position in the backlog. labels Aug 13, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 10, 2020
@engcom-Alfa engcom-Alfa added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Sep 10, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-37578 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: ready for dev and removed Progress: PR in progress labels Sep 10, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: ready for dev labels Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: ready for dev and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Nov 11, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.x Indicates original Magento version for the Issue report. label Nov 13, 2020
@stale
Copy link

stale bot commented Jan 29, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@magento-engcom-team
Copy link
Contributor

Unfortunately, we are archiving this ticket now as it did not get much attention from both Magento Community and Core developers for an extended period. This is done in an effort to create a quality, community-driven backlog which will allow us to allocate the required attention more easily.

Please feel free to comment or reopen according to the Issue reporting guidelines
the ticket if you are still facing this issue on the latest 2.x-develop branch. Thank you for collaboration.

@magento-engcom-team magento-engcom-team removed the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Config Component: Developer Component: Filesystem Component: MessageQueue Component: Setup Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.x Indicates original Magento version for the Issue report. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. stale issue
Projects
Development

Successfully merging a pull request may close this issue.

5 participants