Skip to content

[Issue] Fixed issue where removing breadcrumbs removes the page title #29651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 4 tasks
m2-assistant bot opened this issue Aug 18, 2020 · 6 comments · May be fixed by #29437
Closed
2 of 4 tasks

[Issue] Fixed issue where removing breadcrumbs removes the page title #29651

m2-assistant bot opened this issue Aug 18, 2020 · 6 comments · May be fixed by #29437
Assignees
@realchriswells
Labels
Component: Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.1.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. stale issue

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 18, 2020

This issue is automatically created based on existing pull request: #29437: Fixed issue where removing breadcrumbs removes the page title

Description (*)

There was an issue in the 2.1 branch where if you removed the breadcrumbs via XML:
<referenceBlock name="breadcrumbs" remove="true" />, the page title would also be removed, leaving behind empty <title> tags in the <head>. This fixed in the 2.1 branch, but it seems that some regression has occurred and it is back. I'm reapplying that code change.

Related Pull Requests

The original PR is here.

Manual testing scenarios (*)

  1. Remove breadcrumbs block in XML
  2. Go to the category view or product view page
  3. Check Page title in browser tab

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Catalog Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 18, 2020
@realchriswells realchriswells mentioned this issue Aug 18, 2020
Open
5 tasks
@ghost ghost assigned realchriswells Aug 18, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 18, 2020
@ghost ghost unassigned realchriswells Aug 26, 2020
@denchev
Copy link
Contributor

denchev commented Oct 29, 2020

I can reproduce the issue in 2.4-develop branch.
@magento I am working on this

@ghost ghost assigned realchriswells Nov 2, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.1.x Indicates original Magento version for the Issue report. label Nov 13, 2020
@peterjaap
Copy link
Contributor

Indeed still an issue in 2.4.1.

@ghost ghost unassigned denchev Nov 23, 2020
@krishprakash krishprakash self-assigned this Dec 7, 2020
@m2-assistant
Copy link
Author

m2-assistant bot commented Dec 7, 2020

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash krishprakash added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Dec 7, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-39701 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@stale
Copy link

stale bot commented Apr 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Apr 28, 2021
@stale stale bot closed this as completed May 12, 2021
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot], @realchriswells.

Thank you for your report and collaboration!

The related internal Jira ticket MC-39701 was closed as Fixed.

The fix will be available with the upcoming 2.4.3 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@realchriswells realchriswells

Labels
Component: Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.1.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. stale issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed issue where removing breadcrumbs removes the page title realchriswells/magento2
6 participants
@peterjaap @realchriswells @denchev @magento-engcom-team @krishprakash @github-jira-sync-bot