PayPal Payflow Pro performs delayed capture with incorrect parent transaction ID

[aaronsilber]

Shortly after updating to Magento 2.3.6, our client had a large volume of customers report they had been "charged twice." After investigating this, we found these customers had a lingering authorization (pending transaction) on their cards, in addition to a charge for the full amount of the order. The authorization remains until it expires, typically 30 days.

We found that changes to the Magento_Paypal module introduced in Magento 2.3.6 caused the incorrect parent transaction ID to be used when performing a delayed capture. Instead of using the order's authorization as the parent transaction ID (behavior prior to Magento 2.3.6), the $0.00 vault token authorization for the payment is used as the parent transaction ID.

This causes the authorization to remain open until it expires, and the transaction sent to Payflow is not associated to the original order authorization. Additionally, the transaction displays in Payflow as "Capture" instead of "Delayed Capture".

Merchants with "Payment Action" set to "Sale" are likely not impacted, but we have not tested this.

Preconditions (*)

1. Magento Open Source >= 2.3.6
2. magento/module-paypal >= 100.3.6

Steps to reproduce (*)

1. Set up PayPal Payflow Pro gateway with "Payment Action" set to "Authorization"
2. Place an order with a credit card
3. Capture the order's payment by creating an invoice and choosing to Capture Online

Expected result (*)

1. Magento Transaction is created with parent transaction ID of the authorization created at checkout
2. A "Delayed Capture" transaction is sent to Payflow with a parent transaction ID of the authorization created at checkout
3. Customer observes a new charge on their credit card for the amount of the invoice
4. Customer observes pending transaction disappear from their card immediately, or within several days

Actual result (*)

1. Magento Transaction is created with parent transaction ID of the authorization created at checkout
2. A "Sale" transaction is sent to Payflow with a parent transaction ID of the vault token created at checkout
3. Customer observes a new charge on their credit card for the amount of the invoice
4. Customer observes pending transaction remain on their card for over a week, and until it expires, typically in 30 days
5. Customer contacts merchant and reports they have been "charged twice"

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @aaronsilber. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[aaronsilber]

To fix this for our client, we created a Composer patch that partially reverts the modifications to the parent transaction IDs used in authorize and capture. This patch can be applied by creating a directory "patches", and extracting the attached file to patches/MAGENTO-TWO-30870.patch, and adding the following to composer.json:

        "patches": {
            "magento/module-paypal": {
                "Prevent duplicate authorizations when using Payflow with Delayed Capture": "patches/MAGENTO-TWO-30870.patch"
            }
        }

I'm working on reformatting this as a PR and will attach it once it's ready.

MAGENTO-TWO-30870.zip

[aaronsilber]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @aaronsilber. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @aaronsilber, here is your Magento Instance: https://2afae794f8408637e37923547f6d9a26-2-4-develop.instances.magento-community.engineering
Admin access: https://2afae794f8408637e37923547f6d9a26-2-4-develop.instances.magento-community.engineering/admin_710e
Login: 2f2fe2f0
Password: 1aea50779698

[aaronsilber]

Reproduced this issue on fresh 2.4-develop instance in Payflow Test Mode.

Note how the Magento Transaction displays the correct parent transaction ID for the invoice capture, but reviewing the actual transaction data in Payflow shows the incorrect parent transaction ID was used when submitting the transaction data to Payflow.

Magento transaction data after placing an order:

Payflow transaction data after placing an order:

Magento transaction list after capturing with an invoice:

Magento transaction data for the capture (shows expected parent transaction ID):

Payflow transaction data for the capture; shows incorrect parent transaction ID as well as transaction type "Sale" instead of expected "Delayed Capture":

[aaronsilber]

@magento I am working on this

[m2-assistant]

Hi @aaronsilber! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

[aaronsilber]

@magento add to contributors team

[m2-assistant]

Hi @aaronsilber! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

[aaronsilber]

@magento I am working on this

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @sdzhepa
Thank you for verifying the issue. Based on the provided information internal tickets MC-42279 were created

Issue Available: @sdzhepa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[gabrieldagama]

Hi @aaronsilber. Thank you for your report.
The issue has been fixed in #30885 by @aaronsilber in 2.4-develop branch
Related commit(s):

• fde3fd7bc0964b60f841c9f6f484ba70f836f087
• 0d79d7d89730cc6ee557fb9893d90f822a3ec6e7
• 7c43141f7438551fc4b07d0154109daba8b6308a
• 89c2e12703b595a06414955dc1df6b1b31d4c901
• c00fad647a87f173b8729dcefd89c6dd4bed15d3
• 3a89dfa6532180eb80ae58184d6f1fb57e4f4fc7
• dbbcfc470277afb02b9558d93aa98cb8b7f67fcc

The fix will be available with the upcoming 2.4.3 release.

[0xMatt]

Not fixed in 2.4.3-p1.

When I capture a payment, a sales transaction is made. This doesn't close out the authorization and results in a double charge.

[0xMatt]

To fix this for our client, we created a Composer patch that partially reverts the modifications to the parent transaction IDs used in authorize and capture. This patch can be applied by creating a directory "patches", and extracting the attached file to patches/MAGENTO-TWO-30870.patch, and adding the following to composer.json:

        "patches": {
            "magento/module-paypal": {
                "Prevent duplicate authorizations when using Payflow with Delayed Capture": "patches/MAGENTO-TWO-30870.patch"
            }
        }

I'm working on reformatting this as a PR and will attach it once it's ready.

MAGENTO-TWO-30870.zip

Confirmed this patch fixes the issue on 2.4.3-p1.