[Issue] Fix #11175 - i18n:collect-phrases -m can't find many important Magento phrases - added parsing of the attr translations via $t('Text')

[m2-assistant]

This issue is automatically created based on existing pull request: #31804: Fix #11175 - i18n:collect-phrases -m can't find many important Magento phrases - added parsing of the attr translations via $t('Text')

---

Description (*)

According to the official Magento 2 documentations, there is a way to translate HTML attributes, but this is not covered as well. Here is a text from the documentation:

When a string is added as an attribute of an HTML element:

<input type="text" data-bind="attr: {placeholder: $t('First Name')}" />

Documentation - Strings added in UI component templates

This was of translating attributes does not seem to be used in the Magento 2 itself (if my search is correct). Though,
it is officially documented, is used by some vendors and it can be found in some Q&A on the Internet
(like here - magento.stackexchange.com)

Related Pull Requests

48216f3

Fixed Issues (if relevant)

1. Fixes i18n:collect-phrases -m can't find many important magento phrases  #11175 - i18n:collect-phrases -m can't find many important magento phrases

Manual testing scenarios (*)

1. Add the following code to any Magento .html file, for example app/code/Magento/Catalog/view/frontend/web/template/product/addtocart-button.html

<a data-bind="attr: { title: $t('This is \' test \' data for attribute translation with single quotes'), href: '#'} "></a>
<a data-bind="attr: { title: $t('This is test data for attribute translation with a quote after\'\''), href: '#'} "></a>
<a data-bind="attr: { title: $t('This is test data for attribute translation with a quote after\' \' '), href: '#'} "></a>
<input type="text" data-bind="attr: { placeholder: $t('Attribute translation - Placeholder'), title: $t('Attribute translation - Title') }" />

2. Run the command php bin/magento i18n:collect-phrases app/code/Magento/Catalog/view/frontend/web/template/product/

Expected result: Command output contains phrases in the $t('Text') translations that cat be then used in the i18n files.
i18n output example:

"This is ' test ' data for attribute translation with single quotes","This is ' test ' data for attribute translation with single quotes"
"This is test data for attribute translation with a quote after''","This is test data for attribute translation with a quote after''"
"This is test data for attribute translation with a quote after' ' ","This is test data for attribute translation with a quote after' ' "
"This is "" test "" data with 'href' after translate","This is "" test "" data with 'href' after translate"

Actual result: The above phrases are not present in the output.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[magento-engcom-team]

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-40664 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[gabrieldagama]

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #31804 by @maksymz in 2.4-develop branch
Related commit(s):

• 754ea5fcb1ed51281019235b7095d8152a6ffdc6
• 77daafd4571efbaf93b302076017ea3efd757e91
• f847294d47d95ee171a2b6ea860be68ebeb7aff5

The fix will be available with the upcoming 2.4.3 release.

[magento-engcom-team]

Unfortunately, we are archiving this ticket now as it did not get much attention from both Magento Community and Core developers for an extended period. This is done in an effort to create a quality, community-driven backlog which will allow us to allocate the required attention more easily.

Please feel free to comment or reopen according to the Issue reporting guidelines
the ticket if you are still facing this issue on the latest 2.x-develop branch. Thank you for collaboration.