Skip to content

Auto generated code needs to be marked as API #32011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sivaschenko opened this issue Feb 9, 2021 · 2 comments
Open

Auto generated code needs to be marked as API #32011

sivaschenko opened this issue Feb 9, 2021 · 2 comments
Assignees
@DenisSaltanahmedov
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: dev in progress Project: API Changes Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Milestone
2.5

Comments

@sivaschenko
Copy link
Member

Description

Auto-generated code needs to be marked as API

Details

  1. Auto generated code needs to be marked as @api:
    1. \Magento\Framework\Api\Code\Generator\ExtensionAttributesInterfaceFactoryGenerator
    2. \Magento\Framework\Api\Code\Generator\ExtensionAttributesInterfaceGenerator
    3. \Magento\Framework\Api\Code\Generator\ExtensionAttributesGenerator
    4. \Magento\Framework\MessageQueue\Code\Generator\RemoteServiceGenerator
  2. Factories generated for @api entities must also be marked as @api. Factories for non-@api must not be marked as @api
    1. \Magento\Framework\ObjectManager\Code\Generator\Factory

Testing

Run bin/magento setup:di:compile
Check the generated classes
@sivaschenko sivaschenko added this to the 2.5 milestone Feb 9, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Feb 9, 2021
@sivaschenko sivaschenko mentioned this issue Feb 9, 2021
Open
@DenisSaltanahmedov
Copy link
Contributor

@magento I am working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DenisSaltanahmedov DenisSaltanahmedov

Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: dev in progress Project: API Changes Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Milestone
2.5
Development

No branches or pull requests
2 participants
@sivaschenko @DenisSaltanahmedov