-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Open
Labels
Reported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject itIssue related to Developer Experience and needs help with Triage to Confirm or Reject it
Description
This issue is automatically created based on existing pull request: #39772: [Graphql] applied_to must exist on an orderItem
Description (*)
Due to
applied_to: CartDiscountType! @doc(description:"The type of the entity the discount is applied to.") |
Because this is missing errors will be thrown once the applied_to is missing. There are 2 ways to fix this. Remove the not null requirement on applied_to or adding the applied_to on the order item as well.
I believe adding it to the order item could result in more consistent frontend as we keep the data between cart item and order item te same.
Manual testing scenarios (*)
Create/fetch an order using Graphql that has orderitems with discounts, make sure to get the discounts and applied_to (as defined by the graphql schema).
You will see the following error
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
Reported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject itIssue related to Developer Experience and needs help with Triage to Confirm or Reject it