Skip to content

Typo in message when removing coupon from cart #6994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devonto opened this issue Oct 13, 2016 · 4 comments
Closed

Typo in message when removing coupon from cart #6994

devonto opened this issue Oct 13, 2016 · 4 comments

Comments

@devonto
Copy link

devonto commented Oct 13, 2016

There is a typo in the message being displayed to a user when removing a coupon code. One 'l' when it should be two in 'cancelled'.

\vendor\magento\module-checkout\Controller\Cart\CouponPost.php line 137 is currently:

$this->messageManager->addSuccess(__('You canceled the coupon code.'));

And should be:
$this->messageManager->addSuccess(__('You cancelled the coupon code.'));

@jermenkoo jermenkoo mentioned this issue Oct 13, 2016
@shanevbg
Copy link

http://grammarist.com/spelling/cancel/
In American English, the verb cancel is usually inflected canceled and canceling—with one l. This is not a rule, however, and exceptions are easily found. In varieties of English from outside the U.S., including Canadian, British, and Australian English, cancelled and cancelling are the preferred spellings.

@devonto
Copy link
Author

devonto commented Oct 14, 2016

@shanevbg Thanks.

Might it then be more appropriate to build an official en_GB translation pack for these nuances?

@shanevbg
Copy link

@devonto I would think that would make more sense, than claiming it's "consistent" to use British English piecemeal, for example colour and color (there are many more examples, but I know Magento uses "color" in places).

http://grammarist.com/spelling/color-colour/
Color and colour are different spellings of the same word. Color is the preferred spelling in American English, and colour is preferred in all other main varieties of English.

@piotrekkaminski
Copy link
Contributor

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants