-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Typo in message when removing coupon from cart #6994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
http://grammarist.com/spelling/cancel/ |
@shanevbg Thanks. Might it then be more appropriate to build an official en_GB translation pack for these nuances? |
@devonto I would think that would make more sense, than claiming it's "consistent" to use British English piecemeal, for example colour and color (there are many more examples, but I know Magento uses "color" in places). http://grammarist.com/spelling/color-colour/ |
Thank you for your submission. We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues. Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here). We are closing this GitHub ticket and have moved your request to the new forum. |
There is a typo in the message being displayed to a user when removing a coupon code. One 'l' when it should be two in 'cancelled'.
\vendor\magento\module-checkout\Controller\Cart\CouponPost.php
line 137 is currently:$this->messageManager->addSuccess(__('You canceled the coupon code.'));
And should be:
$this->messageManager->addSuccess(__('You cancelled the coupon code.'));
The text was updated successfully, but these errors were encountered: